Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate physics force and impulse into their own components #880

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Jan 9, 2024

Separate physics force and impulse into their own components.
Remove Physics prefix from physics force, impulse, velocity and mass components

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@fallenatlas fallenatlas self-assigned this Jan 9, 2024
@fallenatlas fallenatlas linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 9, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-02-01 18:33 UTC

@fallenatlas fallenatlas added this to the 0.1 Jammable Engine milestone Jan 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/4)

engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/4)

engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e03d95) 50.82% compared to head (85464bb) 50.82%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   50.82%   50.82%           
=======================================
  Files         131      131           
  Lines        7914     7914           
=======================================
  Hits         4022     4022           
  Misses       3892     3892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/4)

engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/4)

engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/force.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/physics/components/impulse.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added A-Engine B-Physics S-Triage Issues whose priority still has to be figured out labels Jan 10, 2024
@github-actions github-actions bot dismissed stale reviews from themself January 10, 2024 20:24

No Clang-Tidy warnings found so I assume my comments were addressed

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Still needs some discussing on naming the fields

@fallenatlas fallenatlas force-pushed the 864-separate-physics-force-and-impulse-into-their-own-components branch from 8081062 to 948d9e9 Compare January 22, 2024 12:12
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about this, mb. Looks good to me, rebase and merge when you can!

@fallenatlas fallenatlas force-pushed the 864-separate-physics-force-and-impulse-into-their-own-components branch from 5a2b162 to 4692b94 Compare February 1, 2024 16:43
@fallenatlas fallenatlas merged commit 1e8553d into main Feb 1, 2024
10 checks passed
@fallenatlas fallenatlas deleted the 864-separate-physics-force-and-impulse-into-their-own-components branch February 1, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Engine B-Physics S-Triage Issues whose priority still has to be figured out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate physics force and impulse into their own components
2 participants