Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevGamm hacks #812

Merged
merged 4 commits into from
Jan 29, 2024
Merged

DevGamm hacks #812

merged 4 commits into from
Jan 29, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Nov 13, 2023

Description

This branch will contain every dirty hack we deem necessary to make a game for DevGamm.
This will hurt :(

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Nov 13, 2023
@RiscadoA RiscadoA added D-Chaotic We are not sure what this entails A-Meta labels Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-29 22:17 UTC

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c1254c) 49.16% compared to head (b6ff49a) 49.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files         132      132           
  Lines        7881     7881           
=======================================
  Hits         3875     3875           
  Misses       4006     4006           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/assets/assets.cpp Show resolved Hide resolved
@RiscadoA RiscadoA marked this pull request as ready for review January 29, 2024 20:39
@RiscadoA RiscadoA merged commit d42f949 into main Jan 29, 2024
10 checks passed
@RiscadoA RiscadoA deleted the devgamm branch January 29, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta D-Chaotic We are not sure what this entails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants