Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add negative tags #756

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 30, 2023

Description

Adds the .noTag and .noStartupTag methods to Cubos, analogs to .tag and .startupTag but which can be used to apply configuration to all systems except the ones with the given tag. This was implemented by simply storing the negative tag settings on the same tag name prefixed with '!'. Then, when we apply the tag settings to the systems, we first add the tags !x to the system if they're not tagged with x.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples. (I don't think this deserves a sample of its own)

@RiscadoA RiscadoA added this to the 0.0.2 DevGamm milestone Oct 30, 2023
@RiscadoA RiscadoA self-assigned this Oct 30, 2023
@RiscadoA RiscadoA linked an issue Oct 30, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-756/
on branch gh-pages at 2024-02-25 17:39 UTC

@RiscadoA RiscadoA force-pushed the 390-allow-negative-tags-on-the-dispatcher branch from 90a8e6d to fac09bc Compare October 30, 2023 10:44
@RiscadoA RiscadoA enabled auto-merge (rebase) October 30, 2023 10:49
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 37.12%. Comparing base (3ecad40) to head (aaa682f).

Files Patch % Lines
core/src/ecs/cubos.cpp 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   37.03%   37.12%   +0.09%     
==========================================
  Files         302      302              
  Lines       24780    24809      +29     
==========================================
+ Hits         9177     9211      +34     
+ Misses      15603    15598       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA added the S-Stale Has been abandoned, but kept for reference label Jan 25, 2024
@RiscadoA
Copy link
Member Author

Thanks for reviewing this @fallenatlas! Honestly I'm not sure if we should merge this as it is right now.
Since @joaomanita is working on the dispatcher right now and we will have to make big changes to its structure anyway, it probably makes more sense to rethink this later. Marking this as stale and leaving it here, as it might still be useful.

@RiscadoA RiscadoA removed this from the 0.1 Jammable Engine milestone Jan 29, 2024
@RiscadoA RiscadoA added this to the 0.2 Coffee Jammable milestone Feb 25, 2024
@RiscadoA RiscadoA force-pushed the 390-allow-negative-tags-on-the-dispatcher branch from fac09bc to aaa682f Compare February 25, 2024 17:38
@github-actions github-actions bot added the S-Needs-Design Demands some time designing an implementation label Feb 25, 2024
@RiscadoA RiscadoA merged commit 59c21ae into main Feb 25, 2024
11 checks passed
@RiscadoA RiscadoA deleted the 390-allow-negative-tags-on-the-dispatcher branch February 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-ECS S-Needs-Design Demands some time designing an implementation S-Stale Has been abandoned, but kept for reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow negative tags on the dispatcher
2 participants