-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): add negative tags #756
Conversation
|
90a8e6d
to
fac09bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 37.03% 37.12% +0.09%
==========================================
Files 302 302
Lines 24780 24809 +29
==========================================
+ Hits 9177 9211 +34
+ Misses 15603 15598 -5 ☔ View full report in Codecov by Sentry. |
Thanks for reviewing this @fallenatlas! Honestly I'm not sure if we should merge this as it is right now. |
fac09bc
to
aaa682f
Compare
Description
Adds the
.noTag
and.noStartupTag
methods toCubos
, analogs to.tag
and.startupTag
but which can be used to apply configuration to all systems except the ones with the given tag. This was implemented by simply storing the negative tag settings on the same tag name prefixed with '!'. Then, when we apply the tag settings to the systems, we first add the tags!x
to the system if they're not tagged withx
.Checklist
Write new samples.(I don't think this deserves a sample of its own)