Add VoxelPalette iterator
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a fairly simple implementation, however, I'm a bit insecure on how should i test this? Engine tests? |
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 38.15% 38.15%
=======================================
Files 99 99
Lines 6576 6576
=======================================
Hits 2509 2509
Misses 4067 4067 ☔ View full report in Codecov by Sentry. |
roby2014
force-pushed
the
667-allow-iterating-over-voxelpalletes
branch
from
ec2c051
to
a587258
Compare
github-actions
bot
dismissed stale reviews from themself
No clang-tidy warnings found so I assume my comments were addressed
The tests are currently broken :( #564 Ig you can skip it for now |
roby2014
force-pushed
the
667-allow-iterating-over-voxelpalletes
branch
from
68b7be6
to
4b2b33a
Compare
RiscadoA
requested changes
Oct 16, 2023
RiscadoA
approved these changes
Oct 16, 2023
roby2014
force-pushed
the
667-allow-iterating-over-voxelpalletes
branch
from
6d2442c
to
8c2325e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add VoxelPalette iterator
Checklist