Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ID displayed on the World Inspector #714

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

roby2014
Copy link
Member

@roby2014 roby2014 commented Oct 11, 2023

Description

Fixed wrong ID displayed on the World Inspector by using entity.index instead of loop index(n )

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.

@roby2014 roby2014 linked an issue Oct 11, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-15 15:35 UTC

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d967078) 38.15% compared to head (bce2e69) 38.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   38.15%   38.15%           
=======================================
  Files          99       99           
  Lines        6576     6576           
=======================================
  Hits         2509     2509           
  Misses       4067     4067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roby2014 roby2014 self-assigned this Oct 11, 2023
@RiscadoA
Copy link
Member

Will try this on my machine when I get home before approving

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@RiscadoA
Copy link
Member

@DiogoMendonc-a this needs your approval

@roby2014 roby2014 enabled auto-merge (rebase) October 15, 2023 15:02
@roby2014 roby2014 changed the title fix(meta): fixed wrong ID displayed on the World Inspector Wrong ID displayed on the World Inspector Oct 15, 2023
@roby2014 roby2014 force-pushed the 547-world-inspector-shows-wrong-entity-ids branch from 7416465 to bce2e69 Compare October 15, 2023 15:11
@roby2014 roby2014 merged commit 0315a52 into main Oct 15, 2023
9 checks passed
@roby2014 roby2014 deleted the 547-world-inspector-shows-wrong-entity-ids branch October 15, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World inspector shows wrong entity IDs
3 participants