Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(memory): move AnyVector values on reserve #705

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(memory): move AnyVector values on reserve #705

merged 1 commit into from
Oct 11, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 9, 2023 •
edited
Loading

Description

I noticed that AnyVector wasn't calling the move constructor when allocating a new buffer - fixed it here.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA added this to the 0.0.2 DevGamm milestone Oct 9, 2023
@RiscadoA RiscadoA self-assigned this Oct 9, 2023
@RiscadoA RiscadoA linked an issue Oct 9, 2023 that may be closed by this pull request
AnyVector should move values on reallocation #704
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-11 10:32 UTC

@RiscadoA RiscadoA force-pushed the 704-anyvector-should-move-values-on-reallocation branch from 082577d to 5c28eb1 Compare October 9, 2023 08:48
@RiscadoA RiscadoA marked this pull request as ready for review October 9, 2023 08:49
@RiscadoA RiscadoA enabled auto-merge (rebase) October 9, 2023 08:49
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (067b6d6) 38.09% compared to head (7d42538) 38.15%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   38.09%   38.15%   +0.05%     
==========================================
  Files          99       99              
  Lines        6570     6576       +6     
==========================================
+ Hits         2503     2509       +6     
  Misses       4067     4067
Files Coverage Δ
core/src/cubos/core/memory/any_vector.cpp 94.36% <100.00%> (+0.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 704-anyvector-should-move-values-on-reallocation branch from 5c28eb1 to 8d0b7d3 Compare October 9, 2023 13:36
@RiscadoA RiscadoA force-pushed the 704-anyvector-should-move-values-on-reallocation branch from 8d0b7d3 to 7d42538 Compare October 11, 2023 10:14
@RiscadoA RiscadoA merged commit c002b21 into main Oct 11, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 704-anyvector-should-move-values-on-reallocation branch October 11, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

Assignees

@RiscadoA RiscadoA

Labels
A-Core B-Memory
Projects
None yet
Milestone
0.0.2 DevGamm
Development

Successfully merging this pull request may close these issues.

AnyVector should move values on reallocation
2 participants
@RiscadoA @luishfonseca