Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnorderedBimap #696

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Add UnorderedBimap #696

merged 2 commits into from
Oct 8, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 8, 2023 •
edited
Loading

Description

Adds UnorderedBimap.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 8, 2023
@RiscadoA RiscadoA self-assigned this Oct 8, 2023
@RiscadoA RiscadoA linked an issue Oct 8, 2023 that may be closed by this pull request
Implement UnorderedBimap #695
Closed
@RiscadoA RiscadoA force-pushed the 695-implement-unorderedbimap branch from 76005e2 to 4b29fa6 Compare October 8, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-696/
on branch gh-pages at 2023-10-08 15:52 UTC

github-actions[bot]
github-actions bot previously requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/include/cubos/core/memory/unordered_bimap.hpp Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/include/cubos/core/memory/unordered_bimap.hpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA force-pushed the 695-implement-unorderedbimap branch 2 times, most recently from 89303f8 to cc92781 Compare October 8, 2023 15:03
@RiscadoA RiscadoA enabled auto-merge (rebase) October 8, 2023 15:03
github-actions[bot]
github-actions bot previously requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/include/cubos/core/memory/unordered_bimap.hpp Show resolved Hide resolved
@github-actions github-actions bot dismissed stale reviews from themself October 8, 2023 15:04

No clang-tidy warnings found so I assume my comments were addressed

@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (35ba758) 36.35% compared to head (f2cee2a) 36.81%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   36.35%   36.81%   +0.46%     
==========================================
  Files          96       97       +1     
  Lines        6412     6459      +47     
==========================================
+ Hits         2331     2378      +47     
  Misses       4081     4081
Files Coverage Δ
core/include/cubos/core/memory/unordered_bimap.hpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 695-implement-unorderedbimap branch from cc92781 to cb05e1f Compare October 8, 2023 15:23
@luishfonseca luishfonseca dismissed their stale review October 8, 2023 15:41

meant to request changes lmao

luishfonseca
luishfonseca requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@luishfonseca luishfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i meant to do the first time

@RiscadoA RiscadoA merged commit f3ec829 into main Oct 8, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 695-implement-unorderedbimap branch October 8, 2023 16:22
@RiscadoA RiscadoA mentioned this pull request Oct 8, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@RiscadoA RiscadoA

Labels
A-Core B-Memory
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Implement UnorderedBimap
2 participants
@RiscadoA @luishfonseca