Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resource stuff to the ecs/resource directory #650

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 1, 2023

Closes #646.

Description

Moves the resource manager to the ecs/resource directory.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@RiscadoA RiscadoA added A-Core B-ECS C-Code-Quality A section of code that is hard to understand or change S-Blocked Blocked on another issue or PR labels Oct 1, 2023
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 1, 2023
@RiscadoA RiscadoA self-assigned this Oct 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-02 22:32 UTC

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f65b241) 36.56% compared to head (91907ee) 36.56%.
Report is 11 commits behind head on main.

❗ Current head 91907ee differs from pull request most recent head 756bb72. Consider uploading reports for the commit 756bb72 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   36.56%   36.56%           
=======================================
  Files          92       92           
  Lines        6378     6378           
=======================================
  Hits         2332     2332           
  Misses       4046     4046           
Files Coverage Δ
.../include/cubos/core/data/old/serialization_map.hpp 69.23% <ø> (ø)
core/include/cubos/core/ecs/blueprint.hpp 94.73% <100.00%> (ø)
core/include/cubos/core/ecs/component/manager.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/component/registry.hpp 90.00% <ø> (ø)
core/include/cubos/core/ecs/component/storage.hpp 72.72% <ø> (ø)
...e/include/cubos/core/ecs/component/vec_storage.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/entity/entity.hpp 100.00% <100.00%> (ø)
core/include/cubos/core/ecs/entity/manager.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/resource/manager.hpp 86.04% <ø> (ø)
core/include/cubos/core/ecs/system/accessors.hpp 100.00% <ø> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 646-move-resource-stuff-to-the-ecsresource-directory branch from 91907ee to 756bb72 Compare October 2, 2023 22:21
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Oct 2, 2023
@RiscadoA RiscadoA enabled auto-merge (rebase) October 2, 2023 22:21
@RiscadoA RiscadoA merged commit c50da74 into main Oct 2, 2023
7 checks passed
@RiscadoA RiscadoA deleted the 646-move-resource-stuff-to-the-ecsresource-directory branch October 2, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-ECS C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move resource stuff to the ecs/resource directory
2 participants