Store SceneInfo through a pointer instead of by value #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 36.57% 36.57%
=======================================
Files 89 89
Lines 6368 6368
=======================================
Hits 2329 2329
Misses 4039 4039 ☔ View full report in Codecov by Sentry. |
RiscadoA
force-pushed
the
630-clang-tidy-fails-on-scene_editorplugincpp
branch
from
1fa0b37
to
b65bf58
Compare
RiscadoA
changed the title
1 task
DiogoMendonc-a
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #630
Description
Previously compilation was failing due to
std::vector<std::pair<std::string, SceneInfo>>not supporting forward declaredSceneInfoon some compilers.By storing a pointer to
SceneInfoinstead, we make it okay to do so.