Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lib dependencies #617

Merged
merged 13 commits into from
Sep 30, 2023
Merged

Bump lib dependencies #617

merged 13 commits into from
Sep 30, 2023

Conversation

luishfonseca
Copy link
Contributor

@luishfonseca luishfonseca commented Sep 28, 2023

Description

Bumped a bunch of dependencies

Checklist

  • Self-review changes.

@luishfonseca luishfonseca added A-Meta B-Build Related to the build configuration labels Sep 28, 2023
@luishfonseca luishfonseca self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-617/
on branch gh-pages at 2023-09-30 00:24 UTC

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f426a85) 36.57% compared to head (64a9452) 36.57%.

❗ Current head 64a9452 differs from pull request most recent head 2ea3538. Consider uploading reports for the commit 2ea3538 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   36.57%   36.57%           
=======================================
  Files          89       89           
  Lines        6368     6368           
=======================================
  Hits         2329     2329           
  Misses       4039     4039           
Files Coverage Δ
core/src/cubos/core/gl/ogl_render_device.cpp 0.00% <ø> (ø)
core/src/cubos/core/io/glfw_window.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA
Copy link
Member

RiscadoA commented Sep 29, 2023

Don't forget to update the getting started page dependency table.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/src/cubos/core/gl/ogl_render_device.cpp Show resolved Hide resolved
core/src/cubos/core/io/glfw_window.cpp Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review September 29, 2023 22:54

No clang-tidy warnings found so I assume my comments were addressed

@RiscadoA
Copy link
Member

What's the reasoning behind removing the documentation deps?

core/CMakeLists.txt Outdated Show resolved Hide resolved
@luishfonseca luishfonseca merged commit 4345076 into main Sep 30, 2023
7 checks passed
@luishfonseca luishfonseca deleted the bump-deps branch September 30, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta B-Build Related to the build configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants