Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UI Code to the Engine #594

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Move UI Code to the Engine #594

merged 7 commits into from
Sep 27, 2023

Conversation

luishfonseca
Copy link
Contributor

No description provided.

@luishfonseca luishfonseca added A-Core A-Engine C-Code-Quality A section of code that is hard to understand or change P-Backlog Nice to have, but not super important B-ImGui labels Sep 26, 2023
@luishfonseca luishfonseca added this to the 0.0 Nursery milestone Sep 26, 2023
@luishfonseca luishfonseca self-assigned this Sep 26, 2023
@luishfonseca luishfonseca linked an issue Sep 26, 2023 that may be closed by this pull request
Move UI code to the engine plugins #492
Closed
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-594/
on branch gh-pages at 2023-09-27 09:24 UTC

@luishfonseca luishfonseca force-pushed the 492-move-ui-code-to-the-engine-plugins branch from 12e9cee to 4a79a6b Compare September 26, 2023 11:25
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0489cc1) 26.92% compared to head (4d773d6) 29.71%.
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   26.92%   29.71%   +2.79%     
==========================================
  Files          89       86       -3     
  Lines        6797     6158     -639     
==========================================
  Hits         1830     1830              
+ Misses       4967     4328     -639

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA
Copy link
Member

I think the imgui dependency should be moved entirely to the engine side, under the imgui plugin. Whats your opinion on that? Its not as if we're wrapping it in the core.

@luishfonseca
Copy link
Contributor Author

That will be my next commit

@luishfonseca luishfonseca marked this pull request as draft September 26, 2023 12:03
github-actions[bot]
github-actions bot previously requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/include/cubos/engine/imgui/imgui.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review September 27, 2023 01:05

No clang-tidy warnings found so I assume my comments were addressed

@RiscadoA RiscadoA marked this pull request as ready for review September 27, 2023 08:01
@RiscadoA
Copy link
Member

I assume this is no longer draft?

RiscadoA
RiscadoA requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just needs some naming/styling changes.

engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/serialization.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/imgui.hpp Show resolved Hide resolved
engine/src/cubos/engine/imgui/imgui.hpp Outdated Show resolved Hide resolved
@luishfonseca luishfonseca force-pushed the 492-move-ui-code-to-the-engine-plugins branch from 1c9ecb9 to 4d773d6 Compare September 27, 2023 09:37
@luishfonseca luishfonseca enabled auto-merge (rebase) September 27, 2023 09:59
@luishfonseca luishfonseca merged commit 798de30 into main Sep 27, 2023
10 checks passed
@luishfonseca luishfonseca deleted the 492-move-ui-code-to-the-engine-plugins branch September 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@luishfonseca luishfonseca

Labels
A-Core A-Engine B-ImGui C-Code-Quality A section of code that is hard to understand or change P-Backlog Nice to have, but not super important
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Move UI code to the engine plugins
2 participants
@luishfonseca @RiscadoA