Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove headers from CMakeLists #593

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Remove headers from CMakeLists #593

merged 2 commits into from
Sep 26, 2023

Conversation

luishfonseca
Copy link
Contributor

No description provided.

@luishfonseca luishfonseca added C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes A-Meta B-Build Related to the build configuration labels Sep 26, 2023
@luishfonseca luishfonseca self-assigned this Sep 26, 2023
@luishfonseca luishfonseca linked an issue Sep 26, 2023 that may be closed by this pull request
Remove include headers from the CMake sources #485
Closed
@luishfonseca luishfonseca added this to the 0.0 Nursery milestone Sep 26, 2023
RiscadoA
RiscadoA approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-593/
on branch gh-pages at 2023-09-26 10:40 UTC

@RiscadoA
Copy link
Member

Weird that clang format run here, main was unformatted somehow ig?

@luishfonseca luishfonseca merged commit 0489cc1 into main Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (67acf0f) 26.92% compared to head (421573d) 26.92%.

❗ Current head 421573d differs from pull request most recent head ab3d73a. Consider uploading reports for the commit ab3d73a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   26.92%   26.92%           
=======================================
  Files          89       89           
  Lines        6797     6797           
=======================================
  Hits         1830     1830           
  Misses       4967     4967

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luishfonseca luishfonseca deleted the 485-remove-include-headers-from-the-cmake-sources branch September 26, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@luishfonseca luishfonseca

Labels
A-Meta B-Build Related to the build configuration C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Remove include headers from the CMake sources
2 participants
@luishfonseca @RiscadoA