Get rid of core::gl::camera
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 26.92% 26.92%
=======================================
Files 89 89
Lines 6797 6797
=======================================
Hits 1830 1830
Misses 4967 4967 ☔ View full report in Codecov by Sentry. |
fallenatlas
added
A-Core
A-Engine
B-Rendering
C-Code-Quality
RiscadoA
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks for working on this @fallenatlas! LGTM, @luishfonseca has already pointed out some minor nitpicks to fix, I've added some more.
RiscadoA
requested changes
Sep 26, 2023
fallenatlas
force-pushed
the
489-get-rid-of-core-camera
branch
from
937cecf
to
f43f4fc
Compare
|
RiscadoA
approved these changes
Sep 27, 2023
|
LGTM :) btw you can mark my comments as resolved when you push their suggestions, makes it easier to know what has been done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove core camera and replace it with engine camera in renderer.
Checklist