Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split quadrados-gen from quadrados #583

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Split quadrados-gen from quadrados #583

merged 4 commits into from
Sep 25, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 25, 2023 •
edited
Loading

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@RiscadoA RiscadoA linked an issue Sep 25, 2023 that may be closed by this pull request
Extract the quadrados generate cancer from quadrados #582
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-583/
on branch gh-pages at 2023-09-25 11:12 UTC

@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +1.33% 🎉

Comparison is base (3948aad) 25.55% compared to head (827516b) 26.88%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   25.55%   26.88%   +1.33%     
==========================================
  Files          93       90       -3     
  Lines        7173     6817     -356     
==========================================
  Hits         1833     1833              
+ Misses       5340     4984     -356
Files Changed Coverage Δ
tools/quadrados-gen/src/main.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

luishfonseca
luishfonseca requested changes Sep 25, 2023
View reviewed changes
tools/CMakeLists.txt Outdated Show resolved Hide resolved
tools/quadrados-gen/src/main.cpp Outdated Show resolved Hide resolved
RiscadoA and others added 2 commits September 25, 2023 12:11
@RiscadoA RiscadoA merged commit eb1505a into main Sep 25, 2023
8 checks passed
@RiscadoA RiscadoA deleted the 582-extract-the-quadrados-generate-cancer-from-quadrados branch September 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract the quadrados generate cancer from quadrados
2 participants
@RiscadoA @luishfonseca