Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity inspector crashing on entity deletion #545

Merged

Conversation

DiogoMendonc-a
Copy link
Contributor

No description provided.

@DiogoMendonc-a DiogoMendonc-a linked an issue Sep 14, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-545/
on branch gh-pages at 2023-09-14 07:58 UTC

@RiscadoA RiscadoA changed the title fix(engine): fix entity inspector crashing on entity deletion Fix entity inspector crashing on entity deletion Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (502e14c) 24.57% compared to head (cc72570) 24.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   24.57%   24.57%           
=======================================
  Files          90       90           
  Lines        7157     7157           
=======================================
  Hits         1759     1759           
  Misses       5398     5398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Sep 14, 2023
@DiogoMendonc-a DiogoMendonc-a merged commit f09ca17 into main Sep 17, 2023
8 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 477-fix-entity-inspector-crashing-when-entity-is-deleted branch September 17, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Entity Inspector crashing when entity is deleted
2 participants