Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and document engine-sample.events #504

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Cleanup and document engine-sample.events #504

merged 4 commits into from
Sep 25, 2023

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Sep 7, 2023 •
edited
Loading

  • Self-review changes.
  • Evaluate impact on the documentation.

@fallenatlas fallenatlas self-assigned this Sep 7, 2023
@fallenatlas fallenatlas linked an issue Sep 7, 2023 that may be closed by this pull request
Cleanup and document engine-sample.events #471
Closed
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eb1505a) 26.95% compared to head (ceb23ac) 26.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   26.95%   26.95%           
=======================================
  Files          89       89           
  Lines        6800     6800           
=======================================
  Hits         1833     1833           
  Misses       4967     4967

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenatlas fallenatlas changed the title Cleanup and document engine-sample.events Cleanup and document engine-sample.events Sep 7, 2023
@RiscadoA RiscadoA added this to the 0.0 Nursery milestone Sep 8, 2023
@fallenatlas fallenatlas force-pushed the 471-cleanup-and-document-engine-sample-events branch from 51a818e to 3f975e2 Compare September 17, 2023 18:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-504/
on branch gh-pages at 2023-09-25 19:35 UTC

@fallenatlas fallenatlas marked this pull request as ready for review September 17, 2023 20:37
RiscadoA
RiscadoA requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @fallenatlas!
Overall LGTM, just added some minor suggestions.

engine/samples/events/page.md Outdated Show resolved Hide resolved
engine/samples/events/page.md Outdated Show resolved Hide resolved
engine/samples/events/page.md Outdated Show resolved Hide resolved
engine/samples/events/page.md Outdated Show resolved Hide resolved
engine/samples/events/page.md Outdated Show resolved Hide resolved
engine/samples/events/main.cpp Outdated Show resolved Hide resolved
@fallenatlas fallenatlas force-pushed the 471-cleanup-and-document-engine-sample-events branch from 180929b to ceb23ac Compare September 25, 2023 19:34
@fallenatlas fallenatlas merged commit fcc4fef into main Sep 25, 2023
7 checks passed
@fallenatlas fallenatlas deleted the 471-cleanup-and-document-engine-sample-events branch September 25, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@fallenatlas fallenatlas

Labels
A-Engine C-Documentation C-Examples
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Cleanup and document engine-sample.events
2 participants
@fallenatlas @RiscadoA