Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and document engine-sample.cars #503

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Sep 6, 2023

Blocked by #508.

  • Self-review changes.
  • Evaluate impact on the documentation.

@fallenatlas fallenatlas linked an issue Sep 6, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-503/
on branch gh-pages at 2023-09-25 21:25 UTC

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fcc4fef) 26.95% compared to head (061b663) 26.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   26.95%   26.95%           
=======================================
  Files          89       89           
  Lines        6800     6800           
=======================================
  Hits         1833     1833           
  Misses       4967     4967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenatlas fallenatlas self-assigned this Sep 6, 2023
@RiscadoA RiscadoA added this to the 0.0 Nursery milestone Sep 8, 2023
@fallenatlas fallenatlas force-pushed the 469-cleanup-and-document-engine-samplecars branch from b9d08c4 to 0f4734b Compare September 8, 2023 21:48
@fallenatlas fallenatlas marked this pull request as ready for review September 9, 2023 00:59
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @fallenatlas! Added some suggestions

engine/samples/cars/components.hpp Outdated Show resolved Hide resolved
engine/samples/cars/main.cpp Outdated Show resolved Hide resolved
engine/samples/cars/main.cpp Outdated Show resolved Hide resolved
engine/samples/cars/main.cpp Outdated Show resolved Hide resolved
engine/samples/cars/main.cpp Outdated Show resolved Hide resolved
engine/samples/cars/page.md Outdated Show resolved Hide resolved
engine/samples/cars/page.md Outdated Show resolved Hide resolved
engine/samples/cars/page.md Outdated Show resolved Hide resolved
engine/samples/cars/page.md Outdated Show resolved Hide resolved
engine/samples/cars/main.cpp Outdated Show resolved Hide resolved
@RiscadoA
Copy link
Member

RiscadoA commented Sep 9, 2023

Also, I just realized that perhaps we could call this sample engine-sample.voxels. It basically demonstrates how the voxelsPlugin can be used, right?

@fallenatlas
Copy link
Contributor Author

fallenatlas commented Sep 9, 2023

We could do that but maybe the movement part wouldn't really be needed if we were to rename it, because it doesn't really have to do with voxels or rendering, I think. The name cars suggests that it demonstrates that but not exclusively

@RiscadoA
Copy link
Member

RiscadoA commented Sep 9, 2023

Yeah you're right. Unsure if we should simplify this or keep it.
One point in favor of removing the movement would be to have a 'go to' sample for loading voxel models.

Still, I guess it can be nice to have a sample which does more than one thing.
Eventually we'll definitely want to have more complete samples which are playable, a bit like our demo.

What do you think? @fallenatlas @luishfonseca @DiogoMendonc-a

@fallenatlas
Copy link
Contributor Author

I think it makes sense to have samples that don't focus only on one thing, but yeah, I don't know if at this stage it's better to just simplify or if something more "normal" like this is actually useful.

@RiscadoA
Copy link
Member

RiscadoA commented Sep 9, 2023

Well lets simplify it then. Its easier to maintain, and probably more helpful this way - assuming its goal is teaching how to use grid and palette assets.

Maybe the sample should be just a car, without any floor, floating.

@RiscadoA
Copy link
Member

We discussed this in the face to face meeting and decided that the engine samples should all be 'plugin specific', thus we should remove the movement part and leave only the loading a grid and palette part.

engine/samples/voxels/main.cpp Outdated Show resolved Hide resolved
engine/samples/voxels/main.cpp Outdated Show resolved Hide resolved
engine/samples/voxels/output.png Outdated Show resolved Hide resolved
engine/samples/voxels/main.cpp Outdated Show resolved Hide resolved
engine/samples/voxels/page.md Outdated Show resolved Hide resolved
engine/samples/voxels/main.cpp Show resolved Hide resolved
engine/samples/voxels/main.cpp Outdated Show resolved Hide resolved
engine/samples/voxels/page.md Outdated Show resolved Hide resolved
engine/samples/voxels/page.md Outdated Show resolved Hide resolved
@fallenatlas fallenatlas force-pushed the 469-cleanup-and-document-engine-samplecars branch from 5422c09 to ea5c2e0 Compare September 17, 2023 18:04
RiscadoA
RiscadoA previously approved these changes Sep 17, 2023
@RiscadoA RiscadoA added the S-Blocked Blocked on another issue or PR label Sep 17, 2023
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Sep 25, 2023
@fallenatlas fallenatlas force-pushed the 469-cleanup-and-document-engine-samplecars branch from 37a2b84 to 061b663 Compare September 25, 2023 21:24
@fallenatlas fallenatlas merged commit a05b5d0 into main Sep 26, 2023
7 checks passed
@fallenatlas fallenatlas deleted the 469-cleanup-and-document-engine-samplecars branch September 26, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup and document engine-sample.cars
2 participants