-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and document engine-sample.cars
#503
Conversation
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 26.95% 26.95%
=======================================
Files 89 89
Lines 6800 6800
=======================================
Hits 1833 1833
Misses 4967 4967 ☔ View full report in Codecov by Sentry. |
b9d08c4
to
0f4734b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @fallenatlas! Added some suggestions
Also, I just realized that perhaps we could call this sample |
We could do that but maybe the movement part wouldn't really be needed if we were to rename it, because it doesn't really have to do with voxels or rendering, I think. The name cars suggests that it demonstrates that but not exclusively |
Yeah you're right. Unsure if we should simplify this or keep it. Still, I guess it can be nice to have a sample which does more than one thing. What do you think? @fallenatlas @luishfonseca @DiogoMendonc-a |
I think it makes sense to have samples that don't focus only on one thing, but yeah, I don't know if at this stage it's better to just simplify or if something more "normal" like this is actually useful. |
Well lets simplify it then. Its easier to maintain, and probably more helpful this way - assuming its goal is teaching how to use grid and palette assets. Maybe the sample should be just a car, without any floor, floating. |
We discussed this in the face to face meeting and decided that the engine samples should all be 'plugin specific', thus we should remove the movement part and leave only the loading a grid and palette part. |
5422c09
to
ea5c2e0
Compare
37a2b84
to
061b663
Compare
Blocked by #508.