Reorganize core samples into directories #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 24.53% 24.53%
=======================================
Files 86 86
Lines 7009 7009
=======================================
Hits 1720 1720
Misses 5289 5289 ☔ View full report in Codecov by Sentry. |
luishfonseca
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this, core samples were single files in the
core/samplesfolder, e.g.:logging.cpp.This moves them to their own directorie, e.g.:
logging/main.cpp.This allows us to have multiple files per sample, if necessary, and also move the sample docs next to the actual code.
Checklist