Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copying light structs in deferred shading for performance reasons #1356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid copying light structs in deferred shading for performance reasons #1356

wants to merge 1 commit into from

Conversation

tomas7770
Copy link
Contributor

Description

Avoid copying light structs in the deferred shading's fragment shader when calling functions, passing an index to the lights array instead.

This fixes the performance issue in #1345.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@tomas7770 tomas7770 linked an issue Oct 28, 2024 that may be closed by this pull request
Reduce performance overhead of directional shadow support #1345
Open
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1356/
on branch gh-pages at 2024-10-28 22:51 UTC

@tomas7770 tomas7770 marked this pull request as ready for review October 28, 2024 23:54
@tomas7770 tomas7770 requested review from RiscadoA and a team as code owners October 28, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A-Engine B-Rendering C-Optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce performance overhead of directional shadow support
1 participant
@tomas7770