-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1323 move glad into another repository #1336
Conversation
3510d3c
to
7f82a97
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
==========================================
+ Coverage 37.41% 42.49% +5.08%
==========================================
Files 410 409 -1
Lines 33198 29229 -3969
==========================================
Hits 12422 12422
+ Misses 20776 16807 -3969 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changelog thing, I only have two more things to point out:
refactor(build)
would more fitting for the commits instead offix(build)
- If you can, add the Cubos team as a maintainer (?) to the two repos you created.
Thanks for working on this! python is no more 🎉
e4de1ea
to
d1df24b
Compare
I forgot to add the perms mb ^^"" |
@kuukitenshi can you squash the commits into a single one before merging? We try to have a clean git history in main. |
d1df24b
to
ac0ff1b
Compare
… (cubos-glad, cubos-stb)
ac0ff1b
to
9e13050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty! Looks good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Moved
Glad
andstb-image
libs to another repositories,cubos-glad
andcubos-stb
, respectively.Checklist