Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1323 move glad into another repository #1336

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

kuukitenshi
Copy link
Contributor

Description

Moved Glad and stb-image libs to another repositories, cubos-glad and cubos-stb, respectively.

Checklist

  • Self-review changes.
  • Add entry to the changelog's unreleased section.

@kuukitenshi kuukitenshi requested review from RiscadoA and a team as code owners September 28, 2024 18:13
@kuukitenshi kuukitenshi linked an issue Sep 28, 2024 that may be closed by this pull request
@kuukitenshi kuukitenshi force-pushed the 1323-move-glad-into-another-repository branch 2 times, most recently from 3510d3c to 7f82a97 Compare September 28, 2024 19:22
@github-actions github-actions bot added A-Core B-Build Related to the build configuration C-Code-Quality A section of code that is hard to understand or change D-Good-First-Issue Easy but interesting labels Sep 28, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1336/
on branch gh-pages at 2024-09-28 19:24 UTC

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.49%. Comparing base (1286c1a) to head (9e13050).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/src/gl/ogl_render_device.cpp 0.00% 8 Missing ⚠️
core/src/io/glfw_window.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   37.41%   42.49%   +5.08%     
==========================================
  Files         410      409       -1     
  Lines       33198    29229    -3969     
==========================================
  Hits        12422    12422              
+ Misses      20776    16807    -3969     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog thing, I only have two more things to point out:

  • refactor(build) would more fitting for the commits instead of fix(build)
  • If you can, add the Cubos team as a maintainer (?) to the two repos you created.

Thanks for working on this! python is no more 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@RiscadoA RiscadoA added this to the 0.4 milestone Sep 29, 2024
@kuukitenshi kuukitenshi force-pushed the 1323-move-glad-into-another-repository branch 2 times, most recently from e4de1ea to d1df24b Compare September 29, 2024 11:52
@kuukitenshi
Copy link
Contributor Author

Other than the changelog thing, I only have two more things to point out:

  • refactor(build) would more fitting for the commits instead of fix(build)
  • If you can, add the Cubos team as a maintainer (?) to the two repos you created.

Thanks for working on this! python is no more 🎉

I forgot to add the perms mb ^^""

@RiscadoA
Copy link
Member

@kuukitenshi can you squash the commits into a single one before merging? We try to have a clean git history in main.
Probably the easiest way to get it done is git reset --soft HEAD~1 and then git commit --amend - make sure to update the message of the first commit.

@kuukitenshi kuukitenshi force-pushed the 1323-move-glad-into-another-repository branch from d1df24b to ac0ff1b Compare September 29, 2024 12:37
@kuukitenshi kuukitenshi force-pushed the 1323-move-glad-into-another-repository branch from ac0ff1b to 9e13050 Compare September 29, 2024 12:38
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! Looks good to me 🚀

Copy link
Contributor

@mkuritsu mkuritsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kuukitenshi kuukitenshi merged commit f19856a into main Sep 29, 2024
11 checks passed
@kuukitenshi kuukitenshi deleted the 1323-move-glad-into-another-repository branch September 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-Build Related to the build configuration C-Code-Quality A section of code that is hard to understand or change D-Good-First-Issue Easy but interesting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move glad into another repository
4 participants