Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening projects through Tesseratos #1329

Merged
merged 8 commits into from
Oct 13, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 27, 2024

Description

Adds the project plugin, which adds support for the ProjectManager system argument, along with an ImGui window for opening and closing projects + launching them and terminating them.
Also adds an utility class Process to the core to handle multiple processes in a cross-platform way.

There are also some other random fixes or simple methods that I needed to add to other areas in order to make this possible. Looking at the commit history probably gives a better view of what I changed.

I need people with Windows and MacOS to check if this also works in other operating systems

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage. The only part that we could in theory could (easily) test of this is the cross-platform multi process utilities I added, but sadly doctest doesn't handle multi process stuff well at all.
  • Write new samples. You can test it by opening tesseratos, opening the Project window, setting a project folder and a binary/executable path, and launching it. Then you can use the debugger tool to step, run or terminate the game.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.4 milestone Sep 27, 2024
@RiscadoA RiscadoA self-assigned this Sep 27, 2024
@RiscadoA RiscadoA linked an issue Sep 27, 2024 that may be closed by this pull request
@RiscadoA RiscadoA added the S-Blocked Blocked on another issue or PR label Sep 27, 2024
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 54524fd to 964a734 Compare September 27, 2024 17:20
@RiscadoA RiscadoA linked an issue Sep 27, 2024 that may be closed by this pull request
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 964a734 to e396faa Compare September 29, 2024 14:09
Copy link
Contributor

github-actions bot commented Sep 29, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1329/
on branch gh-pages at 2024-10-13 13:37 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/src/thread/process.cpp Outdated Show resolved Hide resolved
core/src/thread/process.cpp Show resolved Hide resolved
core/src/thread/process.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 96bb2e4 to 383985e Compare September 29, 2024 14:29
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 91 lines in your changes missing coverage. Please review.

Project coverage is 40.19%. Comparing base (ff78548) to head (8d18503).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
core/src/thread/process.cpp 0.00% 66 Missing ⚠️
engine/src/assets/bridges/file.cpp 0.00% 14 Missing ⚠️
engine/src/assets/assets.cpp 0.00% 10 Missing ⚠️
core/include/cubos/core/thread/process.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   40.31%   40.19%   -0.12%     
==========================================
  Files         435      437       +2     
  Lines       30908    31003      +95     
==========================================
+ Hits        12461    12463       +2     
- Misses      18447    18540      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 383985e to 2bf5742 Compare October 7, 2024 12:27
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Oct 7, 2024
@RiscadoA RiscadoA marked this pull request as ready for review October 7, 2024 12:42
@RiscadoA RiscadoA requested a review from a team as a code owner October 7, 2024 12:42
@RiscadoA RiscadoA requested review from Docas95, GCeSilva, a team and Scarface1809 and removed request for Docas95, GCeSilva and a team October 7, 2024 12:42
Copy link

cubos-bot bot commented Oct 8, 2024

@kuukitenshi will only be able to review this PR in 3 days.

@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from 1e97a80 to ff9feca Compare October 8, 2024 14:07
Copy link
Contributor

@kuukitenshi kuukitenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all works on Windows ✨
Aside from that, I didn't find any issues or bugs. The code LGTM!

@RiscadoA RiscadoA force-pushed the 1218-allow-opening-projects-through-tesseratos branch from ff9feca to 8d18503 Compare October 13, 2024 13:35
Copy link
Contributor

@diogomsmiranda diogomsmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually Tested for macOS and works!

Why the choice to call it "Update" and not "Step"?

We should later add a more interactive way to add the project path and binary path. Like a File Explorer type thing.

Code LGTM.

@RiscadoA
Copy link
Member Author

RiscadoA commented Oct 13, 2024

Manually Tested for macOS and works!

Why the choice to call it "Update" and not "Step"?

We should later add a more interactive way to add the project path and binary path. Like a File Explorer type thing.

Code LGTM.

Ty for the review!
I used 'update' in order to be consistent with 'update' systems, but yeah, probably changing it to 'step' is more readable.
I'll change the whole UI in the next PR anyway so I'll be leaving it like this for now.
Also, @Scarface1809 has almost finished the file selector tool, so we'll be able to do that on the next version 👀

@RiscadoA RiscadoA merged commit 4545275 into main Oct 13, 2024
11 checks passed
@RiscadoA RiscadoA deleted the 1218-allow-opening-projects-through-tesseratos branch October 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow launching, pausing and restarting the game from the editor Allow opening projects through Tesseratos
4 participants