-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening projects through Tesseratos #1329
Allow opening projects through Tesseratos #1329
Conversation
54524fd
to
964a734
Compare
964a734
to
e396faa
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
96bb2e4
to
383985e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
- Coverage 40.31% 40.19% -0.12%
==========================================
Files 435 437 +2
Lines 30908 31003 +95
==========================================
+ Hits 12461 12463 +2
- Misses 18447 18540 +93 ☔ View full report in Codecov by Sentry. |
383985e
to
2bf5742
Compare
@kuukitenshi will only be able to review this PR in 3 days. |
1e97a80
to
ff9feca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all works on Windows ✨
Aside from that, I didn't find any issues or bugs. The code LGTM!
ff9feca
to
8d18503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually Tested for macOS and works!
Why the choice to call it "Update" and not "Step"?
We should later add a more interactive way to add the project path and binary path. Like a File Explorer type thing.
Code LGTM.
Ty for the review! |
Description
Adds the project plugin, which adds support for the
ProjectManager
system argument, along with an ImGui window for opening and closing projects + launching them and terminating them.Also adds an utility class Process to the core to handle multiple processes in a cross-platform way.
There are also some other random fixes or simple methods that I needed to add to other areas in order to make this possible. Looking at the commit history probably gives a better view of what I changed.
I need people with Windows and MacOS to check if this also works in other operating systems
Checklist
Ensure test coverage.The only part that we could in theory could (easily) test of this is the cross-platform multi process utilities I added, but sadly doctest doesn't handle multi process stuff well at all.Write new samples.You can test it by opening tesseratos, opening the Project window, setting a project folder and a binary/executable path, and launching it. Then you can use the debugger tool to step, run or terminate the game.