-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotation on constraint solving #1315
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
- Coverage 40.84% 40.73% -0.12%
==========================================
Files 430 430
Lines 30409 30500 +91
==========================================
+ Hits 12421 12423 +2
- Misses 17988 18077 +89 ☔ View full report in Codecov by Sentry. |
d2b5396
to
1e0fe6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🥳 Very cool to see rotation being relevant. As usual, I don't really understand what's going on here, so I'll just trust you on the math.
The sample also runs fine on my machine, but I noticed the movement of the boxes is sometimes weird/unnatural? Is it still missing step or something? What's next?
Also, don't forget to add an entry to the changelog! |
Sometimes it still looks weird yeah, I'm not entirely sure of what the problem is, it could be because of the friction and bounciness settings in the sample which could produce something we don't naturally expect, or my guess is that it has to do with the softness parameters, which might be too strong (they limit the velocities for the solving thus making it feel less crispy and more sluggish, but it's important for stability), but I don't fully understand this part yet so it's something that I'll have to look into in the future. |
f2103d5
to
fa2b058
Compare
@fallenatlas Just noticed your commit messages are not very correct:
If you can, change this before merging! |
fa2b058
to
c4c6c3e
Compare
c4c6c3e
to
22dd9a0
Compare
Description
Adds angular velocity computation in penetration constraint solving.
Checklist