Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1292 allow importing voxel models through the asset explorer #1299

Merged
merged 6 commits into from
Oct 7, 2024
Merged

1292 allow importing voxel models through the asset explorer #1299

merged 6 commits into from
Oct 7, 2024

Conversation

Scarface1809
Copy link
Contributor

Description

Allow Importing .grd & .pal files via new VoxelModel assets.

@Scarface1809 Scarface1809 requested review from RiscadoA and a team as code owners August 2, 2024 23:32
@Scarface1809 Scarface1809 linked an issue Aug 2, 2024 that may be closed by this pull request
Allow importing voxel models through the asset explorer #1292
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1299/
on branch gh-pages at 2024-10-05 07:34 UTC

@Scarface1809
Copy link
Contributor Author

Still unfinished, só para reviewers verem e apontarem anything I may be doing wrong.

github-actions[bot]
github-actions bot reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/3)

engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/3)

engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/3)

tools/tesseratos/src/tesseratos/importer/plugin.cpp Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Show resolved Hide resolved
engine/src/voxels/grid.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model_bridge.cpp Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 224 lines in your changes missing coverage. Please review.

Project coverage is 42.13%. Comparing base (7205c59) to head (16e5b0a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/voxels/model.cpp 0.00% 146 Missing ⚠️
engine/src/assets/assets.cpp 0.00% 54 Missing ⚠️
engine/src/voxels/model_bridge.cpp 0.00% 11 Missing ⚠️
engine/src/voxels/grid.cpp 0.00% 9 Missing ⚠️
engine/include/cubos/engine/voxels/model.hpp 0.00% 2 Missing ⚠️
engine/src/voxels/plugin.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   42.45%   42.13%   -0.32%     
==========================================
  Files         410      413       +3     
  Lines       29260    29476     +216     
==========================================
  Hits        12421    12421              
- Misses      16839    17055     +216

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DiogoMendonc-a
DiogoMendonc-a approved these changes Aug 7, 2024
View reviewed changes
engine/src/assets/assets.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA marked this pull request as draft September 27, 2024 06:08
github-actions[bot]
github-actions bot reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/assets/assets.cpp Outdated Show resolved Hide resolved
engine/src/assets/assets.cpp Outdated Show resolved Hide resolved
@Scarface1809 Scarface1809 force-pushed the 1292-allow-importing-voxel-models-through-the-asset-explorer branch 2 times, most recently from afb21ce to 4207f85 Compare September 30, 2024 16:45
github-actions[bot]
github-actions bot reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/src/voxels/voxel_model.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for working on this! This tool will be really useful 👀
I tried giving it a go locally and it fails to open the car.qb (Unsupported version 0.0.0.0, only 1.1.0.0 is supported), which is weird 🤔 is the asset you included valid?

engine/include/cubos/engine/assets/assets.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/assets/assets.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/assets/assets.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/plugin.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/voxels/voxel_model.hpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/asset_explorer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/asset_explorer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
RiscadoA
RiscadoA approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these final comments I added, LGTM!
Ty very much for working on this!
Looking forward to not having to use quadrados for the next demo 👀

engine/include/cubos/engine/voxels/model.hpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/importer/plugin.cpp Show resolved Hide resolved
RiscadoA
RiscadoA reviewed Oct 5, 2024
View reviewed changes
engine/CMakeLists.txt Outdated Show resolved Hide resolved
@Scarface1809 Scarface1809 force-pushed the 1292-allow-importing-voxel-models-through-the-asset-explorer branch from a9ed994 to a3331bd Compare October 5, 2024 07:51
@Scarface1809 Scarface1809 force-pushed the 1292-allow-importing-voxel-models-through-the-asset-explorer branch from a3331bd to 5b66964 Compare October 5, 2024 08:19
@Scarface1809 Scarface1809 marked this pull request as ready for review October 5, 2024 08:25
@Scarface1809 Scarface1809 self-assigned this Oct 5, 2024
@Scarface1809 Scarface1809 force-pushed the 1292-allow-importing-voxel-models-through-the-asset-explorer branch from e5f9993 to 16e5b0a Compare October 6, 2024 15:33
@RiscadoA RiscadoA added this to the 0.4 milestone Oct 7, 2024
@Scarface1809 Scarface1809 merged commit 2ce0d0f into main Oct 7, 2024
11 checks passed
@Scarface1809 Scarface1809 deleted the 1292-allow-importing-voxel-models-through-the-asset-explorer branch October 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@DiogoMendonc-a DiogoMendonc-a DiogoMendonc-a approved these changes

@roby2014 roby2014 roby2014 approved these changes

Assignees

@Scarface1809 Scarface1809

Labels
A-Tesseratos B-Assets
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

Allow importing voxel models through the asset explorer
4 participants
@Scarface1809 @RiscadoA @DiogoMendonc-a @roby2014