Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add Commands::EntityBuilder::named #1074

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Mar 13, 2024

Description

Can be used to give names to entities more easily.
Just shortened .add(Name{"foo}) for .named("foo").

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.

@RiscadoA RiscadoA added this to the 0.2 Coffee Jammable milestone Mar 13, 2024
@RiscadoA RiscadoA self-assigned this Mar 13, 2024
Copy link
Contributor

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1074/
on branch gh-pages at 2024-03-13 17:25 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

core/tests/ecs/commands.cpp Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review March 13, 2024 17:26

No Clang-Tidy warnings found so I assume my comments were addressed

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.90%. Comparing base (f4f7576) to head (4ababe9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   37.90%   37.90%           
=======================================
  Files         304      304           
  Lines       25201    25204    +3     
=======================================
+ Hits         9552     9554    +2     
- Misses      15649    15650    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA merged commit 0642d50 into main Mar 13, 2024
11 checks passed
@RiscadoA RiscadoA deleted the add-commands-named branch March 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant