Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

878 add rotation gizmo #1067

Merged
merged 3 commits into from
Mar 9, 2024
Merged

878 add rotation gizmo #1067

merged 3 commits into from
Mar 9, 2024

Conversation

DiogoMendonc-a
Copy link
Contributor

Adds Rotation Gizmo, fixes a bug, and adds a toggle for global/local axis

Copy link
Contributor

github-actions bot commented Mar 8, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1067/
on branch gh-pages at 2024-03-09 11:28 UTC

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 37.79%. Comparing base (074ff7f) to head (4d3b5ee).

Files Patch % Lines
engine/src/gizmos/types/cut_cone.hpp 0.00% 10 Missing ⚠️
engine/src/gizmos/types/ring.hpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   37.81%   37.79%   -0.02%     
==========================================
  Files         304      304              
  Lines       25260    25270      +10     
==========================================
  Hits         9551     9551              
- Misses      15709    15719      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM 😌
Don't forget to add an entry to the changelog before merging!

@DiogoMendonc-a DiogoMendonc-a merged commit eb42da2 into main Mar 9, 2024
11 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 878-add-rotation-gizmo branch March 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rotation Gizmo
2 participants