Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1002 add world positionrotationscale getters to localtoworld #1031

Merged
merged 3 commits into from
Feb 27, 2024
Merged

1002 add world positionrotationscale getters to localtoworld #1031

merged 3 commits into from
Feb 27, 2024

Conversation

DiogoMendonc-a
Copy link
Contributor

closes #1002 and #1003

@DiogoMendonc-a DiogoMendonc-a self-assigned this Feb 26, 2024
@DiogoMendonc-a DiogoMendonc-a linked an issue Feb 26, 2024 that may be closed by this pull request
Add world position/rotation/scale getters to LocalToWorld #1002
Closed
@github-actions github-actions bot added A-Engine C-Code-Quality A section of code that is hard to understand or change labels Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-1031/
on branch gh-pages at 2024-02-26 21:30 UTC

@RiscadoA
Copy link
Member

Don't forget to update the changelog! (you shouldn't erase the checklist 😤)

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 37.70%. Comparing base (d28c090) to head (b51ad04).

Files Patch % Lines
engine/src/transform/local_to_world.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   37.71%   37.70%   -0.01%     
==========================================
  Files         302      302              
  Lines       25030    25036       +6     
==========================================
  Hits         9441     9441              
- Misses      15589    15595       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RiscadoA
RiscadoA requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should add an entry to the changelog

engine/include/cubos/engine/transform/local_to_world.hpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA linked an issue Feb 26, 2024 that may be closed by this pull request
Transform gizmo uses relative position instead of world position #1003
Closed
@github-actions github-actions bot added C-Bug S-Blocked Blocked on another issue or PR labels Feb 26, 2024
github-actions[bot]
github-actions bot previously requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/transform/local_to_world.cpp Outdated Show resolved Hide resolved
engine/src/transform/local_to_world.cpp Outdated Show resolved Hide resolved
engine/src/transform/local_to_world.cpp Outdated Show resolved Hide resolved
engine/src/transform/local_to_world.cpp Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 1002-add-world-positionrotationscale-getters-to-localtoworld branch from b7858f1 to a2cb961 Compare February 26, 2024 22:42
@github-actions github-actions bot dismissed their stale review February 26, 2024 22:44

No Clang-Tidy warnings found so I assume my comments were addressed

@DiogoMendonc-a DiogoMendonc-a force-pushed the 1002-add-world-positionrotationscale-getters-to-localtoworld branch from a2cb961 to 78be1c6 Compare February 27, 2024 11:44
@DiogoMendonc-a DiogoMendonc-a force-pushed the 1002-add-world-positionrotationscale-getters-to-localtoworld branch from 78be1c6 to b51ad04 Compare February 27, 2024 11:54
@DiogoMendonc-a DiogoMendonc-a merged commit bc3df3b into main Feb 27, 2024
11 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 1002-add-world-positionrotationscale-getters-to-localtoworld branch February 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@roby2014 roby2014 Awaiting requested review from roby2014

Assignees

@DiogoMendonc-a DiogoMendonc-a

Labels
A-Engine A-Tesseratos B-Transform C-Bug C-Code-Quality A section of code that is hard to understand or change S-Blocked Blocked on another issue or PR
Projects
None yet
Milestone
No milestone
2 participants
@DiogoMendonc-a @RiscadoA