test(core): add tests for OnRemove observers

GameDevTecnico · Oct 15, 2024 · aad1941 · aad1941
1 parent 10f8d71
commit aad1941
Showing 1 changed file with 34 additions and 0 deletions.
diff --git a/core/tests/ecs/world.cpp b/core/tests/ecs/world.cpp
@@ -2,6 +2,7 @@
 
 #include <doctest/doctest.h>
 
+#include <cubos/core/ecs/observer/observers.hpp>
 #include <cubos/core/ecs/world.hpp>
 #include <cubos/core/reflection/external/primitives.hpp>
 #include <cubos/core/reflection/type.hpp>
@@ -547,5 +548,38 @@ TEST_CASE("ecs::World")
             CHECK(it->type->is<IntegerRelation>());
         }
     }
+
+    SUBCASE("world remove works correctly with remove observers")
+    {
+        auto foo = world.create();
+        auto bar = world.create();
+
+        world.components(foo).add(IntegerComponent{0});
+        auto columnId = cubos::core::ecs::ColumnId::make(world.types().id<IntegerComponent>());
+        world.observers().hookOnRemove(columnId, cubos::core::ecs::System<void>::make(world, [foo, bar](World& w) {
+                                           w.components(foo).add(ParentComponent{bar});
+                                       }));
+        // Removing IntegerComponent triggers observer, which alters the entity
+        world.components(foo).remove<IntegerComponent>();
+        CHECK_FALSE(world.components(foo).has<IntegerComponent>());
+        CHECK(world.components(foo).has<ParentComponent>());
+    }
+
+    SUBCASE("world destroy works correctly with remove observers")
+    {
+        auto foo = world.create();
+        auto bar = world.create();
+
+        world.components(foo).add(IntegerComponent{0});
+        auto columnId = cubos::core::ecs::ColumnId::make(world.types().id<IntegerComponent>());
+        world.observers().hookOnRemove(columnId, cubos::core::ecs::System<void>::make(world, [foo, bar](World& w) {
+                                           w.components(foo).add(ParentComponent{bar});
+                                           w.components(bar).add(ParentComponent{foo});
+                                       }));
+        // Destroying foo triggers observer, which alters the entity
+        world.destroy(foo);
+        CHECK_FALSE(world.isAlive(foo));
+        CHECK(world.components(bar).has<ParentComponent>());
+    }
 }
 // NOLINTEND(readability-function-size)