IECoreArnold : Add location names to warning messages #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the needle-in-a-haystack search triggered by the previous non-specific warnings. Most of this is all straightforward, but there are a couple of things worth noting : - `ShapeAlgo::convertP()` no longer throws if it doesn't find "P". Instead it just outputs a warning and the render continues. This is more in keeping with our general "Renderers don't throw" approach. - `ShapeAlgo::convertRadius()` gained the `messageContext` argument but doesn't currently use it. Since this is our chance to make the ABI break needed to improve the messaging, it seemed worth adding for potential future use.
|
Code all looks reasonable, and the things you noted sound good to me. I'm having a slightly hard time picturing what the final resulting messages are like after following things through multiple layers, with no tests showing what things end up looking like ... I'm mostly just wondering whether we might want to sometimes include what is being, as well as the location name where the failure happens? Or maybe that will end up being obvious in context - regardless, this definitely seems like an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the needle-in-a-haystack search triggered by the previous non-specific warnings.
Most of this is all straightforward, but there are a couple of things worth noting :
ShapeAlgo::convertP()no longer throws if it doesn't find "P". Instead it just outputs a warning and the render continues. This is more in keeping with our general "Renderers don't throw" approach.ShapeAlgo::convertRadius()gained themessageContextargument but doesn't currently use it. Since this is our chance to make the ABI break needed to improve the messaging, it seemed worth adding for potential future use.