Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper : Set PYTHONNOUSERSITE=1 #6042

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

johnhaddon
Copy link
Member

This removes a common cause of conflicts between Gaffer and Python modules the user has installed using the system Python. Users who know what they are doing and want to use those modules in Gaffer can set PYTHONNOUSERSITE=0 before running Gaffer to get the prior behaviour.

Confession : I have not tested the gaffer.cmd changes - I am relying on Windows CI and review to do that.

@johnhaddon johnhaddon self-assigned this Sep 13, 2024
Copy link
Collaborator

@ericmehl ericmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And I confirmed it works as expected on Windows.

This removes a common cause of conflicts between Gaffer and Python modules the user has installed using the system Python. Users who know what they are doing and want to use those modules in Gaffer can set `PYTHONNOUSERSITE=0` before running Gaffer to get the prior behaviour.

Confession : I have not tests the `gaffer.cmd` changes - I an relying on Windows CI and review to do that.
@johnhaddon johnhaddon merged commit aacb11c into GafferHQ:main Sep 18, 2024
5 checks passed
@johnhaddon johnhaddon deleted the pythonNoUserSite branch October 1, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants