Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorChooser Color Wheel #5999

Open
wants to merge 2 commits into
base: 1.4_maintenance
Choose a base branch
from

Conversation

ericmehl
Copy link
Collaborator

@ericmehl ericmehl commented Aug 9, 2024

This changes the type of color field to a color wheel instead of the rectangular field when hue is being visualized. So it's active when the static color is set to saturation or value.

For drawing the field, the 50 pixel bitmap with bilinear scaling up to the widget size gives pretty good performance and doesn't introduce too much inaccuracy compared to drawing the field at the full resolution. But as we discussed yesterday, it probably could be much better if we did the drawing in GLSL or c++, which is probably worth investigating as a follow-up.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ericmehl ericmehl changed the base branch from main to 1.4_maintenance August 9, 2024 15:34
@ericmehl ericmehl mentioned this pull request Aug 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant