DotNodeGadget : Use ContextTracker to evaluate custom label #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. The only thing that gave me pause was confirming that it's OK to pass a null context to Context::Scope - after looking at it, pretty sure it is the convention that this must be valid, and doesn't do anything to the stack. Probably doesn't need documenting here, but it might be worth documenting in the header for Context, which currently says: "/// Constructing the Scope pushes the current context." and "/// It is the caller's responsibility to guarantee that |
This also fixes a bug where in the past we didn't update context-sensitive labels when the global context changed.
johnhaddon
force-pushed
the
dotContextTracker
branch
from
07d8150
to
a3a76ed
Compare
|
Added suggested comment in Context.h, and merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug where in the past we didn't update context-sensitive labels when the global context changed.