Skip to content

Commit

Permalink
RenderPassEditor : Add render:defaultRenderer column
Browse files Browse the repository at this point in the history
This is in desperate need of custom widgets for editing options, so we can provide a presets menu. But I think that will be better tackled more holistically, considering the requirements of other columns too. The current goal is to get the basic functionality in quickly to avoid Cinesite having to roll their own.
  • Loading branch information
johnhaddon committed Mar 15, 2024
1 parent 992d11e commit 8f140c0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Features

- Render, InteractiveRender : Added new nodes capable of rendering to any supported renderer, and using the`render:defaultRenderer` option to determine which to use by default.
- StandardOptions : Added `render:defaultRenderer` option, allowing the scene globals to specify which renderer is used by the Render and InteractiveRender nodes.
- RenderPassEditor : Added a column for the `render:defaultRenderer` option, allowing each pass to be rendered in a different renderer.

1.3.13.1 (relative to 1.3.13.0)
========
Expand Down
11 changes: 11 additions & 0 deletions startup/GafferScene/standardOptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@
"""
)

Gaffer.Metadata.registerValue( "option:render:defaultRenderer", "label", "Renderer" )
Gaffer.Metadata.registerValue( "option:render:defaultRenderer", "defaultValue", "" )
Gaffer.Metadata.registerValue(
"option:render:defaultRenderer",
"description",
"""
Specifies the default renderer to be used by the Render and
InteractiveRender nodes.
"""
)

Gaffer.Metadata.registerValue( "option:render:inclusions", "label", "Inclusions" )
Gaffer.Metadata.registerValue( "option:render:inclusions", "defaultValue", IECore.StringData( "/" ) )
Gaffer.Metadata.registerValue(
Expand Down
1 change: 1 addition & 0 deletions startup/gui/renderPassEditor.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
GafferSceneUI.RenderPassEditor.registerOption( "*", "render:exclusions" )
GafferSceneUI.RenderPassEditor.registerOption( "*", "render:additionalLights" )

GafferSceneUI.RenderPassEditor.registerOption( "*", "render:defaultRenderer", "Render" )
GafferSceneUI.RenderPassEditor.registerOption( "*", "render:camera", "Render" )
GafferSceneUI.RenderPassEditor.registerOption( "*", "render:resolution", "Render" )
GafferSceneUI.RenderPassEditor.registerOption( "*", "render:resolutionMultiplier", "Render" )
Expand Down

0 comments on commit 8f140c0

Please sign in to comment.