Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue 39 -smart bulletin and added nav structure for policies and audits section #188

Merged
merged 27 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
29053a3
initial check in for smart bulletin
weiwang-gsa Jul 12, 2023
5be494e
added additional menu to side nav to support smart bulletin
weiwang-gsa Jul 12, 2023
64a75be
get the bone structure up for Policies
weiwang-gsa Jul 12, 2023
98dbfd1
fix 508 issue
weiwang-gsa Jul 12, 2023
c384919
change side nave to use yaml data too
mark-meyer Jul 12, 2023
a0e5b18
Merge pull request #191 from GSA/mmeyer/patch-issue39
weiwang-gsa Jul 12, 2023
b8b5f74
Merge branch 'main' into wwang-issue39
weiwang-gsa Jul 12, 2023
14659a4
Adjust Audit Repository to suite for 2 level side nav
weiwang-gsa Jul 13, 2023
2a873aa
Fixed the page title
weiwang-gsa Jul 13, 2023
f2b45e7
fix pa11y complaints
weiwang-gsa Jul 13, 2023
1c7ee13
remove debug info
weiwang-gsa Jul 13, 2023
d7617f0
Update the yaml file, adjust table width
weiwang-gsa Jul 13, 2023
d7bd1c8
Fix path typos
Jul 13, 2023
2f50dbf
Merge pull request #197 from GSA/rj-wwang-issue39
weiwang-gsa Jul 13, 2023
7f3aa50
fix file name and link button issue
weiwang-gsa Jul 13, 2023
085bfd0
sync changes
weiwang-gsa Jul 13, 2023
08ddad1
fix link button issue
weiwang-gsa Jul 13, 2023
658adaa
remove unncessary code
weiwang-gsa Jul 13, 2023
c029355
Fixes document path
Jul 13, 2023
aa2c6bc
Merge branch 'wwang-issue39' into rj-wwang-issue39
brentryanjohnson Jul 13, 2023
1ec69df
Merge pull request #199 from GSA/rj-wwang-issue39
weiwang-gsa Jul 13, 2023
75f155e
update smart bulletins contents
weiwang-gsa Jul 13, 2023
f81918d
Merge branch 'wwang-issue39' of https://github.com/GSA/smartpay-websi…
weiwang-gsa Jul 13, 2023
643579d
update yaml and added remaining files
weiwang-gsa Jul 14, 2023
fdbfb1e
added missing pdf file and correct typos
weiwang-gsa Jul 14, 2023
2bd472b
clean up code and move top nav into SinglePageSideNav
weiwang-gsa Jul 14, 2023
e77b973
add aria-hidden for icon img
weiwang-gsa Jul 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
3 changes: 3 additions & 0 deletions src/assets/images/previous-nav-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions src/components/LinkButton.astro
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
---
const { text, link } = Astro.props;
const { text, link, parent_nav_path } = Astro.props;
const isInternal = link.includes("http")? false: true
---
{isInternal? <a href={`${import.meta.env.BASE_URL}${link}`} class="usa-button">{text}</a>:<a href={link} class="usa-button">{text}</a>}



<a href={link} class="usa-button">{text}</a>
5 changes: 2 additions & 3 deletions src/components/SideNav.astro
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
const { id, pages, headings, parent_path, title} = Astro.props;
const { id, pages, headings, parent_path, title, additional_menu=null} = Astro.props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like the additional_menu props is used in the component. Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely, will clean it up

pages.sort((a, b) => parseInt(a.data.order) - parseInt(b.data.order))

---
<div class="usa-layout-docs__sidenav desktop:grid-col-4">
<nav class="sp_site_nav" aria-label="Secondary navigation">
Expand All @@ -11,7 +10,7 @@ pages.sort((a, b) => parseInt(a.data.order) - parseInt(b.data.order))
<li class:list={["usa-sidenav__item", {current: id === page.id }]}>
<a
class={id === page.id ? 'usa-current' : null }
href={`${import.meta.env.BASE_URL}${parent_path}/${page.slug}`}
href={`${import.meta.env.BASE_URL}${parent_path}/${page.slug || page.id}`}
>{page.data.title}
</a>
<ul class="usa-sidenav__sublist">
Expand Down
9 changes: 9 additions & 0 deletions src/components/TopNav.astro
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
const { parent_nav_path, parent_nav_text} = Astro.props;
import previousNavIcon from '../assets/images/previous-nav-icon.svg'
const url = `${import.meta.env.BASE_URL}${parent_nav_path}`

---
<div class="display-flex margin-bottom-2" style="width:100%">
<img src={previousNavIcon} alt="left Arrow icon for navigation back to Policies and Audits"><a class="usa-link" href={`${import.meta.env.BASE_URL}${parent_nav_path}`}>Return to the {parent_nav_text}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can talk about how these links will work when Kristen is back, but in general we don't want screen readers to see the icons. The code in https://designsystem.digital.gov/components/pagination/ is a good example — they implement the arrow icon with aria-hidden="true" role="img" to prevent screen readers from see the icon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, per our discussion, I keep current top nav using link (matching mockup) for now, once we talked to Kirsten, we can update the TopNav based on final decision, thanks!

</div>
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- VA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.va.gov/oig/pubs/VAOIG-13-02267-124.pdf" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.gao.gov/products/OIG-15-2" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DHS
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.oversight.gov/report/dhs/fiscal-year-2015-risk-assessment-dhs-bank-card-program-indicates-moderate-risk" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.dodig.mil/Reports/Compendium-of-Open-Recommendations/Article/1119310/dod-officials-did-not-take-appropriate-action-when-notified-of-potential-travel/" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOI
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.doioig.gov/reports/audit/us-department-interiors-internal-controls-purchase-cards-and-fleet-cards-0" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- EPA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.epa.gov/office-inspector-general/report-epa-oversight-travel-cards-needs-improve" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.gao.gov/products/GAO-16-526" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.gao.gov/products/GAO-16-657" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- EPA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.epa.gov/office-inspector-general/report-risk-epas-fiscal-year-2016-purchase-card-and-convenience-check" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.gao.gov/products/GAO-17-276" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- SSA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2017-ssa-purchase.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2017-ssa-purchase.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- USPS
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.uspsoig.gov/reports/audit-reports/fleet-specialty-credit-cards-eastern-area" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- VA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.oversight.gov/report/va/review-alleged-irregular-use-purchase-cards-vha%E2%80%99s-engineering-service-carl-vinson-va" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- CIGIE
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://oversight.gov/report/cigie/report-government-purchase-card-initiative" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.dodig.mil/reports.html/Article/1485315/dod-reporting-of-charge-card-misuse-to-omb/" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- CIGIE
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.oversight.gov/report/dos/inspector-general-statement-department-state%E2%80%99s-major-management-and-performance" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.gao.gov/products/GAO-18-371SP" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- Amtrak
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://amtrakoig.gov/sites/default/files/reports/OIG-A-2019-013%20Controls%20Over%20PCards.pdf" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.dodig.mil/reports.html/Article/1938309/audit-of-the-air-force-nonappropriated-fund-government-purchase-card-program-do/" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.dodig.mil/reports.html/Article/1920236/audit-of-the-dods-management-of-the-cybersecurity-risks-for-government-purchase/" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- DOD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2019-dod-travel.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2019-dod-travel.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- DOI
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2019-doi-purchase.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2019-doi-purchase.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- GSA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2019-gsa-purchase.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2019-gsa-purchase.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- GSA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2019-gsa-travel.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2019-gsa-travel.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- NSA
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.oversight.gov/report/nsa/audit-agency%E2%80%99s-travel-program" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tags:
- DOT
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="https://www.oig.dot.gov/library-item/37777" text="View Full Audit" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- GAO
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/gao-disaster-response.pdf" text="View Full Audit" />
<LinkButton link="/files/audits/2020-gao-disaster-response.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- HUD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2020-hud-purchase.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2020-hud-purchase.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- HUD
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2020-hud-travel.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2020-hud-travel.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ tags:
- SEC
---

import LinkButton from '../../../components/LinkButton.astro';
import LinkButton from '../../components/LinkButton.astro';

<LinkButton link="/files/audits/2020-sec-travel.pdf" text="View Full Audit" />
<LinkButton link="files/audits/2020-sec-travel.pdf" text="View Full Audit" />

## Background

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
title: Audit Repository
description: "The Audit Repository includes agency audits related to the GSA SmartPay program."
intro: "The Audit Repository includes both multi-agency and agency-specific audits related to the GSA SmartPay program."
slug: "./"
order: 0
order: 2
category: policies and audits
tags:
- policy
Expand All @@ -21,7 +20,7 @@ tags:

## 2019

- March: [The National Security Agency (NSA) Audit of the Agency’s Travel Program AU-18-0003](/policies-and-audits/audits/2019/nsa-travel)
- March: [The National Security Agency (NSA) Audit of the Agency’s Travel Program AU-18-0003](/policies-and-audits/audits/2019-nsa-travel)
- July: [Audit of the Department of Defense’s (DoD) Management of the Cybersecurity Risks for Government Purchase Card Purchases of Commercial Off-the-Shelf Items DoDIG-2019-106](/policies-and-audits/audits/2019-dod-purchase)
- August: [DoD Should Strengthen Its Ongoing Actions to Reduce Improper Travel Payments](/policies-and-audits/audits/2019-dod-travel)
- August: [Audit of the Air Force Nonappropriated Fund Government Purchase Card Program DoDIG-2019-113](/policies-and-audits/audits/2019-dod-air-force-purchase)
Expand All @@ -34,7 +33,7 @@ tags:

- April: [2017 Annual Report: Additional Opportunities to Reduce Fragmentation, Overlap, and Duplication and Achieve Other Financial Benefits](/policies-and-audits/audits/2018-gao)
- April: [DoD Reporting of Charge Card Misuse to OMB](/policies-and-audits/audits/2018-dod-purchase-travel)
- July: [Report on the Government Purchase Card Initiative](/policies-and-audits/audits/cigie/purchase)
- July: [Report on the Government Purchase Card Initiative](/policies-and-audits/audits/2018-cigie-purchase)
- November: [The Department of State’s Major Management And Performance Challenges](/policies-and-audits/audits/2018-dos)

## 2017
Expand All @@ -43,15 +42,15 @@ tags:
- February: [Government Purchase Cards: Little Evidence of Potential Fraud Found in Small Purchases, but Documentation Issues Exist](/policies-and-audits/audits/2017-gao-purchase)
- February: [Risk for Environmental Protection Agency’s (EPA) Fiscal Year 2016 Purchase Card and Convenience Check Program Warrants an Audit](/policies-and-audits/audits/2017-epa-purchase)
- March: [United States Postal Service (USPS) Fleet Specialty Credit Cards - Eastern Area](/policies-and-audits/audits/2017-usps-fleet)
- June: [Veterans Health Administration (VAMC): Review of Alleged Irregular Use of Purchase Cards by the Engineering Service at the Carl Vinson VA Medical Center in Dublin, Georgia](/policies-and-audits/audits/va-purchase)
- June: [Veterans Health Administration (VAMC): Review of Alleged Irregular Use of Purchase Cards by the Engineering Service at the Carl Vinson VA Medical Center in Dublin, Georgia](/policies-and-audits/audits/2017-va-purchase)

## 2016

- May: [Government Purchase Cards: Opportunities Exist to Leverage Buying Power](/policies-and-audits/audits/2016-gao-purchase)
- July: [Federal Travel: Opportunities Exist to Improve Data and Information Sharing](/policies-and-audits/audits/2016-gao-travel)
- August: [DoD Officials Did Not Take Appropriate Action When Notified of Potential Travel Card Misuse at Casinos and Adult Entertainment Establishments](/policies-and-audits/audits/2016-dod-travel)
- August: [EPA Oversight of Travel Cards Needs to Improve](/policies-and-audits/audits/2016-epa-travel)
- September: [Fiscal Year 2015 Risk Assessment of the Department of Homeland Security (DHS) Bank Card Program Indicates Moderate Risk](/policies-and-audits/audits/2016-dha-purchase)
- September: [Fiscal Year 2015 Risk Assessment of the Department of Homeland Security (DHS) Bank Card Program Indicates Moderate Risk](/policies-and-audits/audits/2016-dhs-purchase)
- October: [DOI’s Internal Controls For Purchase Cards And Fleet Cards](/policies-and-audits/audits/2016-doi-purchase-fleet)

## 2015
Expand Down
6 changes: 6 additions & 0 deletions src/content/policies-and-audits/policies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Policies
order: 1
---

Content is coming soon
Loading