-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve issue 39 -smart bulletin and added nav structure for policies and audits section #188
Changes from 25 commits
29053a3
5be494e
64a75be
98dbfd1
c384919
a0e5b18
b8b5f74
14659a4
2a873aa
f2b45e7
1c7ee13
d7617f0
d7bd1c8
2f50dbf
7f3aa50
085bfd0
08ddad1
658adaa
c029355
aa2c6bc
1ec69df
75f155e
f81918d
643579d
fdbfb1e
2bd472b
e77b973
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
--- | ||
const { text, link } = Astro.props; | ||
const { text, link, parent_nav_path } = Astro.props; | ||
const isInternal = link.includes("http")? false: true | ||
--- | ||
{isInternal? <a href={`${import.meta.env.BASE_URL}${link}`} class="usa-button">{text}</a>:<a href={link} class="usa-button">{text}</a>} | ||
|
||
|
||
|
||
<a href={link} class="usa-button">{text}</a> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
const { parent_nav_path, parent_nav_text} = Astro.props; | ||
import previousNavIcon from '../assets/images/previous-nav-icon.svg' | ||
const url = `${import.meta.env.BASE_URL}${parent_nav_path}` | ||
|
||
--- | ||
<div class="display-flex margin-bottom-2" style="width:100%"> | ||
<img src={previousNavIcon} alt="left Arrow icon for navigation back to Policies and Audits"><a class="usa-link" href={`${import.meta.env.BASE_URL}${parent_nav_path}`}>Return to the {parent_nav_text}</a> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can talk about how these links will work when Kristen is back, but in general we don't want screen readers to see the icons. The code in https://designsystem.digital.gov/components/pagination/ is a good example — they implement the arrow icon with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure, per our discussion, I keep current top nav using link (matching mockup) for now, once we talked to Kirsten, we can update the TopNav based on final decision, thanks! |
||
</div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
title: Policies | ||
order: 1 | ||
--- | ||
|
||
Content is coming soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem like the
additional_menu
props is used in the component. Can we remove it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely, will clean it up