Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds about section content #152

Merged
merged 10 commits into from
Jun 29, 2023
Merged

Adds about section content #152

merged 10 commits into from
Jun 29, 2023

Conversation

brentryanjohnson
Copy link
Contributor

@brentryanjohnson brentryanjohnson commented Jun 28, 2023

  • ✍️ Adds about section content in markdown
  • 🚧 Formats links for Mmeyer/process markdown links #154 but needs testing (and cloud.gov Pages internal links will likely not work)
  • ❗ Doesn't close all about issues, for reasons described below
  • 🤷 YouTube embeds (compared to 11ty) are verbose. It's the whole darn iframe for now. (I changed the width to 100% and gently asked YouTube for no recommendations)

Notes

There are some issues closed (upon review) by this PR. Other issues are not possible with markdown and need additional dev. I have noted both instances below.

One issue significantly diverges from its respective Figma prototype, which I have also noted.

Issues closed

Closes #34 #38 #30 #48 #38

Needs more dev

Issue #37 (Business Lines)

  • Two-column layout with images
  • Requires link to FAQ (not yet built)

Issue #141

  • We changed this page, decoupling refunds from refund reporting.
  • This page (along with Business Lines #37) has some version of horizontal rules. hr elements are in this PR (because available in markdown), but not ideal, since they output in the DOM. A CSS border might be more appropriate. For now, this issue is not closed for this reason and...
  • The spacing between headings and borders is unresolved relative to Figma designs.

Footnotes

  • We (unfortunately) found it appropriate to use footnotes in one instance (Refunds), and the markdown supported it! But it does autogenerate a subheading (creatively called Footnotes). I don't know if we can customize this subheading, but it's both a different font, and we would ideally change the heading to Sources. I also have no idea if we can control what level of heading it generates.

Departures from Figma

  • Our engineering + design crossover revealed that bundling general refunds info with refunds reporting (in the context of Statistics and Reports didn't work programmatically, and was ultimately confusing. This unwinds part of a larger consolidation of statistics-related content. The consolidation makes sense overall, but this background piece (as a separate page) didn't fit.
  • Reorders content on Statistics and Reports landing page — instead of leading with Refunds, this change leads with the Program Statistics summary, then Sales, Transactions, Account Holder Data, then Purchase Card FPDS Reports, and finally Refund Reporting. The reason for the change is to start with the summary of the information and the more general statistical information, followed by more specific reports.
  • Already mentioned, but issue Refunds Overview #35 is now a separate page from Statistics and Reports landing page #141

Additions from issue

🔍 Previews

@brentryanjohnson brentryanjohnson changed the title [WIP] Adds about section content Adds about section content Jun 28, 2023
@brentryanjohnson brentryanjohnson marked this pull request as ready for review June 29, 2023 01:50
Copy link
Contributor

@weiwang-gsa weiwang-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benefits of the Program
2 participants