Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home page changes #151

Merged
merged 8 commits into from
Jun 28, 2023
Merged

home page changes #151

merged 8 commits into from
Jun 28, 2023

Conversation

weiwang-gsa
Copy link
Contributor

  • added call out section
  • adjusted business line section
  • adjusted hero section
  • added home style
  • changed default font for h1, h2 and h3 and color based on new design

Copy link
Contributor

@mark-meyer mark-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just two comments about links.

<div class="tablet:grid-col-6">
<h2>State Tax Information</h2>
<p>Check the tax-exempt status and policies of U.S. states and territories.</p>
<p><a href="/statetax/">Go to tax information →</a></p>
Copy link
Contributor

@mark-meyer mark-meyer Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need to put ${import.meta.env.BASE_URL} in front of any links starting with / otherwise the links won't work for federalist previews. Alternatively, we could just do relative links: href="statetax/" like you did with the Find out more link.

src/components/Callout.astro Outdated Show resolved Hide resolved
Copy link
Contributor

@mark-meyer mark-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiwang-gsa weiwang-gsa merged commit ea92759 into main Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants