-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home page changes #151
home page changes #151
Conversation
weiwang-gsa
commented
Jun 27, 2023
- added call out section
- adjusted business line section
- adjusted hero section
- added home style
- changed default font for h1, h2 and h3 and color based on new design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just two comments about links.
src/components/Callout.astro
Outdated
<div class="tablet:grid-col-6"> | ||
<h2>State Tax Information</h2> | ||
<p>Check the tax-exempt status and policies of U.S. states and territories.</p> | ||
<p><a href="/statetax/">Go to tax information →</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to put ${import.meta.env.BASE_URL}
in front of any links starting with /
otherwise the links won't work for federalist previews. Alternatively, we could just do relative links: href="statetax/"
like you did with the Find out more
link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM