Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable new dataset creation on catalog #4161

Closed
3 tasks
FuhuXia opened this issue Jan 19, 2023 · 6 comments
Closed
3 tasks

disable new dataset creation on catalog #4161

FuhuXia opened this issue Jan 19, 2023 · 6 comments
Assignees
@FuhuXia @btylerburton
Labels
bug Software defect or bug component/catalog Related to catalog component playbooks/roles

Comments

@FuhuXia
Copy link
Member

FuhuXia commented Jan 19, 2023 •
edited by btylerburton
Loading

All datasets on catalog are supposed to be harvested, not manually added. But we saw datasets created by user.

How to reproduce

Log into dev and hit /dataset/new.

Expected behavior

UI tells the user that the action is not allowed.

Actual behavior

User can create dataset

Sketch

  • Remove "Add Dataset" button from template that generates the dashboard/datasets route
  • Locate and remove any other instances of that button
  • Block the route at the NGINX level, which should not affect tests within our GH Actions.
@FuhuXia FuhuXia added the bug Software defect or bug label Jan 19, 2023
@hkdctol hkdctol moved this to 📔 Product Backlog in data.gov team board Jan 19, 2023
@hkdctol hkdctol added the component/catalog Related to catalog component playbooks/roles label Aug 3, 2023
@hkdctol hkdctol moved this from 📔 Product Backlog to 📟 Sprint Backlog [7] in data.gov team board Aug 3, 2023
@btylerburton btylerburton self-assigned this Aug 9, 2023
@btylerburton btylerburton moved this from 📟 Sprint Backlog [7] to 🏗 In Progress [8] in data.gov team board Aug 9, 2023
@btylerburton btylerburton moved this from 🏗 In Progress [8] to 📟 Sprint Backlog [7] in data.gov team board Aug 17, 2023
@btylerburton btylerburton removed their assignment Aug 17, 2023
@btylerburton
Copy link
Contributor

We have a lot of tests that are dependent on this route. There is also a button on the profile home when you login. I believe that we should think a bit more about this. Kicking it back.

@hkdctol
Copy link
Contributor

hkdctol commented Aug 24, 2023

Possibly get rid of the button on the template, wherever there is a add a dataset button, disable route on nginx

@btylerburton
Copy link
Contributor

Updated sketch

@btylerburton btylerburton moved this from 📟 Sprint Backlog [7] to 🏗 In Progress [8] in data.gov team board Aug 28, 2023
@btylerburton btylerburton self-assigned this Aug 28, 2023
@btylerburton btylerburton moved this from 🏗 In Progress [8] to New Dev in data.gov team board Aug 29, 2023
@btylerburton btylerburton moved this from New Dev to 📟 Sprint Backlog [7] in data.gov team board Aug 29, 2023
@btylerburton btylerburton removed their assignment Aug 29, 2023
@btylerburton btylerburton moved this from 📟 Sprint Backlog [7] to 🏗 In Progress [8] in data.gov team board Sep 5, 2023
@btylerburton btylerburton self-assigned this Sep 5, 2023
This was referenced Sep 11, 2023
Merged
Merged
@btylerburton btylerburton moved this from 🏗 In Progress [8] to ✔ Done in data.gov team board Sep 14, 2023
@hkdctol hkdctol closed this as completed Sep 15, 2023
@hkdctol hkdctol moved this from ✔ Done to 🗄 Closed in data.gov team board Sep 15, 2023
@FuhuXia
Copy link
Member Author

FuhuXia commented Oct 23, 2023

As of now, anything starts with /dataset/new is blocked as in /dataset/new-hampshire-and-southern-maine-ocean-uses-atlas.

@FuhuXia FuhuXia reopened this Oct 23, 2023
@github-project-automation github-project-automation bot moved this from 🗄 Closed to 📟 Sprint Backlog [7] in data.gov team board Oct 23, 2023
@Jin-Sun-tts Jin-Sun-tts mentioned this issue Oct 23, 2023
Closed
10 tasks
@FuhuXia FuhuXia mentioned this issue Oct 24, 2023
Merged
@FuhuXia FuhuXia self-assigned this Oct 24, 2023
@FuhuXia
Copy link
Member Author

FuhuXia commented Oct 24, 2023

This is resolved.

@FuhuXia FuhuXia closed this as completed Oct 24, 2023
@github-project-automation github-project-automation bot moved this from 📟 Sprint Backlog [7] to ✔ Done in data.gov team board Oct 24, 2023
@FuhuXia FuhuXia mentioned this issue Oct 25, 2023
Closed
10 tasks
@Jin-Sun-tts
Copy link
Contributor

verified in the New Relic log, this issue is resolved.

Screenshot 2023-10-25 at 4 21 02 PM

@hkdctol hkdctol moved this from ✔ Done to 🗄 Closed in data.gov team board Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FuhuXia FuhuXia

@btylerburton btylerburton

Labels
bug Software defect or bug component/catalog Related to catalog component playbooks/roles
Projects
data.gov team board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FuhuXia @hkdctol @btylerburton @Jin-Sun-tts