-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable new dataset creation #1070
Conversation
Won't build until CF fixes the key, but at least we can get this in. |
@@ -80,3 +80,8 @@ error_page 500 502 503 504 /500.html; | |||
location = /500.html { | |||
root ./public; | |||
} | |||
|
|||
# prevent users from accessing '/dataset/new' route | |||
location = /dataset/new { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we block on nginx level, why not add more paths to block some API calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion. what are you thinking of? and is this for unrelated things or is this needed to block dataset creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think api dataset creation (/api/action/package_create
, resource_create
, ... not sure of the entire list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two (package_create
, resource_create
) should be good to add to the block list, kind of equivalent to ui /dataset/new
. There are more actions such as package_update
and alike that we want to keep for our deduping purpose or other manual API calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While that's fine for now, if we start using the harvester2.0 we'll need to re-enable those routes to get data to CKAN...
• blocks
/dataset/new
route in nginxRelated to: