Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PUBLIC_ROUTE into nginx server_name #1046

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Add PUBLIC_ROUTE into nginx server_name #1046

merged 5 commits into from
Aug 30, 2023

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Aug 30, 2023

For GSA/data.gov#4413

On CloudFront we will add HOST and USER-AGENT into the header. We need to change nginx conf accordingly. This is the 3-step deployment.

  1. Add PUBLIC_ROUTE as new host, but disable nginx-cloudfront check
  2. TODO: apply new CloudFront settings
  3. TODO: re-enable nginx-cloudfront check.

@FuhuXia FuhuXia requested a review from a team August 30, 2023 14:08
@nickumia-reisys nickumia-reisys mentioned this pull request Aug 30, 2023
Closed
nickumia-reisys
nickumia-reisys previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

nickumia-reisys
nickumia-reisys approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎 🐎

@nickumia-reisys nickumia-reisys merged commit 8c76a34 into main Aug 30, 2023
6 checks passed
@nickumia-reisys nickumia-reisys deleted the ngnix-cloudfront-setting branch August 30, 2023 14:58
@FuhuXia
Copy link
Member Author

FuhuXia commented Aug 30, 2023

This PR broke catalog because the step 3 commit was pushed prematurely. will redo step 1, 2, 3.

@FuhuXia FuhuXia mentioned this pull request Aug 30, 2023
Merged
@nickumia-reisys nickumia-reisys mentioned this pull request Aug 31, 2023
Closed
@FuhuXia FuhuXia mentioned this pull request Aug 31, 2023
Merged
@nickumia-reisys nickumia-reisys mentioned this pull request Sep 18, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickumia-reisys nickumia-reisys nickumia-reisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuhuXia @nickumia-reisys