Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support proxy for freshclam #1

Merged
merged 6 commits into from
May 30, 2023

Conversation

asteel-gsa
Copy link

@asteel-gsa asteel-gsa commented May 24, 2023

Test Case (with ajilaag/clamav-rest image):

/etc/clamav # ./test.sh 
Replaced proxy server #=> ensuring sed works with new delimiter when testing
Replaced proxy port #=> ensuring sed works with new delimiter when testing
Replaced proxy user and pass #=> ensuring sed works with new delimiter when testing

/etc/clamav # cat freshclam.conf | grep "HTTP*"
# The HTTPProxyServer may be prefixed with [scheme]:// to specify which kind
#   http://     HTTP Proxy. Default when no scheme or proxy type is specified.
#   https://    HTTPS Proxy. (Added in 7.52.0 for OpenSSL, GnuTLS and NSS)
HTTPProxyServer https://proxy-test.com
HTTPProxyPort 54321
HTTPProxyUsername TESTUSER
HTTPProxyPassword TEST/PASS
#HTTPUserAgent SomeUserAgentIdString

Usage:
If $PROXY_SERVER is not set in an environment variable, then none of this will run
If $PROXY_SERVER is set then replace the value in freshclam.conf

  • Since port, username and password are not required, only apply them to freshclam.conf if $PROXY_PORT, $PROXY_USERNAME and $PROXY_PASSWORD are set in an environment variable

@asteel-gsa asteel-gsa requested a review from mogul May 24, 2023 19:50
@asteel-gsa
Copy link
Author

Merge PR from Upstream into GSA-TTS managed repo.
Follow on: Create workflow to Build, Scan and Tag

@asteel-gsa asteel-gsa marked this pull request as ready for review May 24, 2023 19:52
@asteel-gsa asteel-gsa changed the title Feature/support proxy for freshclam Feature/support proxy for freshclam [DO NOT MERGE - TESTING] May 25, 2023
@asteel-gsa asteel-gsa changed the title Feature/support proxy for freshclam [DO NOT MERGE - TESTING] Feature/support proxy for freshclam May 25, 2023
@asteel-gsa
Copy link
Author

Tested the workflow here which publishes a package in ghcr.io here

@mogul
Copy link

mogul commented May 27, 2023

@asteel-gsa can you make GSA-TTS/fac-admins administrators and GSA-TTS/fac-team writers on this repo?

Copy link

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but if the artifact we upload isn't actually in use, let's comment as to why it's there or remove it.

.github/workflows/build-image.yml Outdated Show resolved Hide resolved
@asteel-gsa
Copy link
Author

@asteel-gsa can you make GSA-TTS/fac-admins administrators and GSA-TTS/fac-team writers on this repo?

I do not have settings on the repo, so I am unsure if I am able to add them

@asteel-gsa asteel-gsa merged commit 51c2ef4 into master May 30, 2023
@asteel-gsa asteel-gsa deleted the feature/support-proxy-for-freshclam branch May 30, 2023 12:06
mogul pushed a commit that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants