Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for toggle-floating-panes action #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add support for toggle-floating-panes action #4

wants to merge 5 commits into from

Conversation

JonnyLoughlin
Copy link
Contributor

Added support for a command I use frequently plus a user command and its default keybinding.

@JonnyLoughlin
Copy link
Contributor Author

Forgot to update the README, will fix

@JonnyLoughlin
Copy link
Contributor Author

This needs additional work. The locking doesn't toggle properly with floating panes. I will fix this up

@GR3YH4TT3R93
Copy link
Owner

Looks good other than the README has an issue with keybinds (A-t rather than A-f) and there's a typo in mappings.lua (ToggleFloatingPanges rather than ToggleFloatingPanes). Once those are fixed, I'd be happy to merge!

@JonnyLoughlin
Copy link
Contributor Author

Thanks for catching that!

After some more testing, zellij-autolock doesn't seem to be functioning correctly with floating panes. I'm not very versed with Rust but I will take a look to see if I can figure out why, and, I'll file an issue over there.

I will fix the README but I still think this PR should wait to be merged until after I can figure this out since it may cause confusion if it isn't working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonnyLoughlin @GR3YH4TT3R93