-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of erroneous copy of pre-split tags to new split meshes #34
Merged
alexbenedicto
merged 20 commits into
main
from
origin/benedicto/bugfix/issue#31_pre_split_tags
Oct 14, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
53fd564
First correction now allowing for the copy of fields from the origina…
alexbenedicto 4615f63
Module import paths update
alexbenedicto 0f8c2ba
Fields are now copied correctly for fracture_mesh.
alexbenedicto 4cee143
Test case added to check the __copy_fields feature.
alexbenedicto 6759376
Invalid packages import for geos-mesh, impacting documentation (#32)
alexbenedicto a392c4b
Correction for yapf valid format.
alexbenedicto 9cf4007
Had to make a workaround to avoid a weird yapf formatting suggestion.
alexbenedicto b8bc706
Mistake correction
alexbenedicto c64a6ba
First correction now allowing for the copy of fields from the origina…
alexbenedicto 5343cf6
Module import paths update
alexbenedicto 29f01a3
Fields are now copied correctly for fracture_mesh.
alexbenedicto 269b09b
Test case added to check the __copy_fields feature.
alexbenedicto 779ae68
Correction for yapf valid format.
alexbenedicto a6f1d68
Had to make a workaround to avoid a weird yapf formatting suggestion.
alexbenedicto 2179463
Mistake correction
alexbenedicto 278adc9
Merge branch 'origin/benedicto/bugfix/issue#31_pre_split_tags' of htt…
alexbenedicto 8495595
First part of review corrections
alexbenedicto 47b6380
Second part correction of reviews
alexbenedicto a4ff5e5
Last part of correction review
alexbenedicto b763288
Updated method when linking old cells to new cells ids to copy correc…
alexbenedicto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# Empty |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be creating our own logger instance that we can set verbosity level on:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also do that in another PR because this is done also in all 'check' files