Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add install commands to component libraries #3307

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Aug 27, 2024

In #3282 I failed to install the shared libraries. This PR adds the required install command.

resolves #3305

@rrsettgast rrsettgast self-assigned this Aug 27, 2024
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (42966e9) to head (f9e14b5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3307   +/-   ##
========================================
  Coverage    56.46%   56.46%           
========================================
  Files         1059     1059           
  Lines        89458    89458           
========================================
  Hits         50512    50512           
  Misses       38946    38946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast merged commit 9019f15 into develop Aug 27, 2024
24 of 40 checks passed
@rrsettgast rrsettgast deleted the bugfix/installComponentLibs branch August 27, 2024 22:37
@Algiane
Copy link
Contributor

Algiane commented Aug 29, 2024

We still have a blind spot in the ci: to avoid making a similar mistake again, shouldn't we test that the geos installation works somewhere in the ci.
I haven't look at the implementation of the integrated tests:

  • do they call the geos runtime ?
  • if yes, I guess that the good way is to call the runtime located inside the install dir rather than the one of the binary dir?
  • if it is already the case: shouldn't we try to understand why the ci was not failing and the reproduce the setting that made the non-regression tests of Pangea fail ?

See PR #3313

@paveltomin
Copy link
Contributor

CC @drmichaeltcvx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run Geos on Pangea 3 with shared libraries
5 participants