Add SuSAv2 EM QE hadron tensors separated by hit nucleon isospin #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroda88
requested changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After last genie Core developer meeting, I made some changes according to the suggestions.
The existing implementation of the SuSAv2 EM QE model doesn't distinguish between struck protons and neutrons, leading to an incorrect equal cross section for p and n knockout. Liang Liu (@LiangLiu212) has added tensors from Guillermo Megias separated by isospin, together with code to handle them correctly for cross section calculations and event generation.