-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work on Pythia8 interface and potential for no Pythia6 #308
Open
nusense
wants to merge
35
commits into
GENIE-MC:master
Choose a base branch
from
nusense:rhatcher/complete_pythia8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork/Conventions/GBuild.h
…usion of EGPythia6 dependent on GOPT_ENABLE_PYTHIA6
…ork/Conventions/GBuild.h
Converted it to a draft PR to reinforce the "do not merge" message |
Thanks for making it a "draft" ... I didn't know how to do that. |
…root_config_status
nusense
changed the title
DO NOT MERGE - work on Pythia8 interface and potential for no Pythia6
work on Pythia8 interface and potential for no Pythia6
Dec 21, 2023
Here are the necessary modifications to XML config files in order to run fully with Pythia8 and no Pythia6: (ugh, putting XML code here doesn't work correctly, but one can get the gist of it all from this) $ git diff AGKY2019.xml diff --git a/config/AGKY2019.xml b/config/AGKY2019.xml index f09c6dc..157501a 100644 --- a/config/AGKY2019.xml +++ b/config/AGKY2019.xml @@ -24,7 +24,7 @@ KNO2PYTHIA-Wmax double No relevant only for method=2 KNO2Pythia genie::AGKYLowW2019/Default - genie::Pythia6Hadro2019/Default + genie::Pythia8Hadro2019/Default $ git diff AGKYLowW2019.xml diff --git a/config/AGKYLowW2019.xml b/config/AGKYLowW2019.xml index 50fb5d1..e1c9536 100644 --- a/config/AGKYLowW2019.xml +++ b/config/AGKYLowW2019.xml @@ -169,7 +169,7 @@ KNO-PhaseSpDec-ReweightParm double Yes parameter controlling the reweig true - genie::Pythia6Decayer2023/Default + genie::Pythia8Decayer2023/Default @@ -179,7 +179,7 @@ KNO-PhaseSpDec-ReweightParm double Yes parameter controlling the reweig true - genie::Pythia6Decayer2023/Default + genie::Pythia8Decayer2023/Default false false $ git diff DISHadronicSystemGenerator.xml diff --git a/config/DISHadronicSystemGenerator.xml b/config/DISHadronicSystemGenerator.xml index ce78b82..51de284 100644 --- a/config/DISHadronicSystemGenerator.xml +++ b/config/DISHadronicSystemGenerator.xml @@ -40,7 +40,7 @@ NUCL-NR double No - genie::AGCharmPythia6Hadro2023/Default + genie::AGCharmPythia8Hadro2023/Default genie::UnstableParticleDecayer/BeforeHadronTransport false $ git diff UnstableParticleDecayer.xml diff --git a/config/UnstableParticleDecayer.xml b/config/UnstableParticleDecayer.xml index 49af36c..08237ba 100644 --- a/config/UnstableParticleDecayer.xml +++ b/config/UnstableParticleDecayer.xml @@ -13,19 +13,19 @@ Name Type Optional Comment Default 2 - genie::Pythia6Decayer2023/BeforeHadronTransport + genie::Pythia8Decayer2023/BeforeHadronTransport genie::BaryonResonanceDecayer/BeforeHadronTransport 2 - genie::Pythia6Decayer2023/AfterHadronTransport + genie::Pythia8Decayer2023/AfterHadronTransport genie::BaryonResonanceDecayer/AfterHadronTransport 3 - genie::Pythia6Decayer2023/AfterHadronTransport + genie::Pythia8Decayer2023/AfterHadronTransport genie::BaryonResonanceDecayer/AfterHadronTransport genie::DarkSectorDecayer/Default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a work in progress. Making a pull request to anticipate future pull and allow others to see what is being done.