✨ Feature - Header #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimseohyun
requested review from
seochan99,
bunju20,
naarang,
puretension and
bianbbc87
Closed
4 tasks
seochan99
approved these changes
May 4, 2024
| @@ -13,7 +13,8 @@ | |||
| "next": "14.1.3", | |||
| "react": "^18", | |||
| "react-dom": "^18.2.0", | |||
| "react-icons": "^5.0.1" | |||
| "react-icons": "^5.0.1", | |||
There was a problem hiding this comment.
다음번엔 Tailwind 아이콘으로 써드파트 추가해보는건 어떨지 ㅎㅅㅎ
| export default function Navigation() { | ||
| const pathname = usePathname(); // 현재 경로를 가져오기 | ||
|
|
||
| const [isProjectOpen, setIsProjectOpen] = useState(false); |
There was a problem hiding this comment.
이 파일 리펙토링 한번 필요할듯! 너무 무거움!
유틸 따로 뺄수있을듯합니다
HEY!!!!!!!!!! CHANGE!!!!! PR NAME!!!
|
|
제가 충돌 수정했음 |
sorry 경기버스 network error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
해더, 모바일 스와이퍼 구현
변경 사항
코드 리뷰시 참고 사항
이미지의 경우 추후 작업해서 마무리 하겠습니다.
stories 부분 스와이퍼가 두개 뜨고 있는데 이것도 1차 피드백 이후 애니메이션 형태에 맞추어 수정하며 수정하겠습니다