Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Feat: Member 피드백 반영, 폰트, 색상, 반응형, favicon #38

Merged
merged 16 commits into from
May 4, 2024

Conversation

bunju20
Copy link
Contributor

@bunju20 bunju20 commented May 1, 2024

PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )


  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

개요


반응형으로 수정

CleanShot 2024-05-01 at 20 23 02@2x

CleanShot 2024-05-01 at 20 21 10@2x

CleanShot 2024-05-01 at 20 21 50@2x

CleanShot 2024-05-01 at 20 22 11@2x

페비콘 추가

아래에서 검정색으로 세팅은 해놨는데, 혹시 몰라서 밝은 색도 이미지에 넣어놔서 바로 고칠수있게 만들어놨습니다.
CleanShot 2024-05-01 at 20 26 14@2x

변경 사항

#29 진행했습니다. 반응형으로 변경되도록, 파비콘, 폰트 및 색상 수정하였고 자잘한 디자인 수정 완료했습니다!
5/2일 모션 추가 완료했습니다.

코드 리뷰시 참고 사항

GA는 gdsc계정을 이후에 주시면 제가 달고, 메타데이터 썸네일 이슈로 서현님께서 썸네일 만드신뒤 진행하신다고 합니다! 피드백은 감사합니다!

@bunju20 bunju20 added 🎨 Design 마크업 & 스타일링 ✨ Feature 기능 개발 🙋‍♀️ 현정 작업 labels May 1, 2024
@bunju20 bunju20 self-assigned this May 1, 2024
코드 깔끔하게 수정해야함.
@seochan99
Copy link
Member

GA해드릴게여..

Copy link
Member

@puretension puretension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!!

Copy link
Contributor

@bianbbc87 bianbbc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

Copy link
Member

@seochan99 seochan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어요~ 대괄호만 바꿔주고 머지하면될듯!

src/app/member/page.tsx Outdated Show resolved Hide resolved
src/constants/member/devRel.ts Outdated Show resolved Hide resolved
tailwind.config.ts Show resolved Hide resolved
@bunju20 bunju20 requested a review from seochan99 May 3, 2024 17:40
Copy link
Contributor

@naarang naarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!☺️

Copy link
Member

@seochan99 seochan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿잡입니다:₩

@bunju20 bunju20 merged commit 22617da into GDSC-DGU:dev May 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Design 마크업 & 스타일링 ✨ Feature 기능 개발 🙋‍♀️ 현정 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants