Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ’„Design: ์ƒ‰์ƒ ๋ฐ ํ…์ŠคํŠธ ํฌ๊ธฐ ์ ์šฉ #35 #36

Merged
merged 11 commits into from
May 4, 2024
Merged

๐Ÿ’„Design: ์ƒ‰์ƒ ๋ฐ ํ…์ŠคํŠธ ํฌ๊ธฐ ์ ์šฉ #35 #36

merged 11 commits into from
May 4, 2024

Conversation

seochan99
Copy link
Member

PR ํƒ€์ž… ( ํ•˜๋‚˜ ์ด์ƒ์˜ PR ํƒ€์ž…์„ ์„ ํƒํ•ด์ฃผ์„ธ์š” )


  • ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์˜์กด์„ฑ, ํ™˜๊ฒฝ ๋ณ€์ˆ˜, ๋นŒ๋“œ ๊ด€๋ จ ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ
  • ๊ธฐํƒ€ ์‚ฌ์†Œํ•œ ์ˆ˜์ •

๊ฐœ์š”


์„œํ˜„๋‹˜๊ป˜์„œ ๋งŒ๋“ค์–ด์ฃผ์‹  ํ…์ŠคํŠธ, ์ปฌ๋Ÿฌ Class์ ์šฉ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค.

๋ณ€๊ฒฝ ์‚ฌํ•ญ


ํฐํŠธ ๋ฐ ์ปฌ๋Ÿฌ ์ฝ”๋“œ

์ฝ”๋“œ ๋ฆฌ๋ทฐ์‹œ ์ฐธ๊ณ  ์‚ฌํ•ญ


์—†์Œ.

@seochan99 seochan99 added ๐ŸŽจ Design ๋งˆํฌ์—… & ์Šคํƒ€์ผ๋ง ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿ™‹โ€โ™‚๏ธ ํฌ์ฐฌ ์ž‘์—… labels Apr 30, 2024
@seochan99 seochan99 self-assigned this Apr 30, 2024
@seochan99 seochan99 linked an issue Apr 30, 2024 that may be closed by this pull request
[๐Ÿ’„Design] RecruitํŽ˜์ด์ง€ ๋ฐ˜์‘ํ˜• ์ฒ˜๋ฆฌ #35
Closed
4 tasks
@seochan99 seochan99 changed the title โœจFeat: ์ƒ‰์ƒ ๋ฐ ํ…์ŠคํŠธ ํฌ๊ธฐ ์ ์šฉ #35 ๐Ÿ’„Design: ์ƒ‰์ƒ ๋ฐ ํ…์ŠคํŠธ ํฌ๊ธฐ ์ ์šฉ #35 Apr 30, 2024
puretension
puretension approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@puretension puretension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~!

bianbbc87
bianbbc87 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@bianbbc87 bianbbc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

bunju20
bunju20 approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@bunju20 bunju20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~!!

naarang
naarang approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@naarang naarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~!โ˜บ๏ธ

@seochan99 seochan99 merged commit ce87fb0 into dev May 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bianbbc87 bianbbc87 bianbbc87 approved these changes

@puretension puretension puretension approved these changes

@naarang naarang naarang approved these changes

@bunju20 bunju20 bunju20 approved these changes

@shimseohyun shimseohyun Awaiting requested review from shimseohyun

Assignees

@seochan99 seochan99

Labels
๐ŸŽจ Design ๋งˆํฌ์—… & ์Šคํƒ€์ผ๋ง ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๐Ÿ™‹โ€โ™‚๏ธ ํฌ์ฐฌ ์ž‘์—…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[๐Ÿ’„Design] RecruitํŽ˜์ด์ง€ ๋ฐ˜์‘ํ˜• ์ฒ˜๋ฆฌ
5 participants
@seochan99 @bunju20 @naarang @puretension @bianbbc87