Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding join button #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nsundriyal62
Copy link
Contributor

@nsundriyal62 nsundriyal62 commented Oct 28, 2023

Fixes Issue

Closes #184

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

s1

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ❌ Failed (Inspect) Nov 1, 2023 5:51am

@nsundriyal62
Copy link
Contributor Author

@Vishal-raj-1 hello sir

i know last time you mentioned some changes in this PR
Recent days i have some medical problem and unable to work on changes
so i raising this PR again and now works on those changes too.

thanks.

<p>Learn HTML, CSS, JS and Git & Github</p>
<div className="flex-grow"></div>
<div className="text-center mt-4">
<a href="/join/learn" className="rounded-full px-4 py-2" style={{ textAlign: 'center', color: 'black', backgroundColor: 'white', borderRadius: '18px', fontSize: '16px', width: 'fit-content', margin: '0 auto', padding: '8px 16px' }}>Join</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a style object and use that. copy pasting same style every place is not a good practice

@nsundriyal62
Copy link
Contributor Author

@Vishal-raj-1 sir,

i make all the changes but there are some deployement issue
in case this is not resolved then i will raise a new pr
and also i attach the screenshot for deployment proof.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join button in batches
2 participants