Cursor hover #218

monisanees270798 · 2023-10-15T09:23:58Z

Fixes Issue

Closes Issue #202

Changes proposed

List of changes proposed by my PR

Rewritten the entire tracks.tsx with easy to understand logic
Added feature to zoom in when cursor hovers over .svg images under batch section of HomePage
A supporting CSS file was created to do so (styles directory -> tracks.module.css)

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
[ x] My change requires changes to the documentation.
[ x] I have updated the documentation accordingly.
[ x] All new and existing tests passed.
[ x] This PR does not contain plagiarized content.
[ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I made sure my code does not create any bugs within the rest of your website. Please let me know if there are any issues with my PR getting accepted.

1. Rewrote the existing code and added additional hover code in an understandable way (tracks.tsx) 2. A supporting CSS file has been added to styles dir to support hover zoom ----------------------------------------------- I will complete the .md file and initiate a PR

vercel · 2023-10-15T09:24:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
frontendfreaks	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 21, 2023 0:17am

github-actions

Thank you for your pull request and welcome to our community! We will be getting back to you soon . Your patience will be greatly appreciated! Thanks! 🥳

ManishBisht777

Left some comments

ManishBisht777 · 2023-10-16T05:32:16Z

styles/tracks.module.css

@@ -0,0 +1,10 @@
+/* components/Tracks.module.css */
+
+.image-container {


can't we do it with tailwind only? instead of adding plain stylesheet?

Yes definitely, I tried and it worked. Can you recheck the PR request?
@ManishBisht777 @Vishal-raj-1

1. Rewrote the existing code with tailwind CSS only (tracks.tsx) 2. The supporting CSS file has been removed from styles dir -----------------------------------------------

ManishBisht777

Looks good just remove the unused imports

ManishBisht777 · 2023-10-19T05:56:41Z

components/tracks.tsx

@@ -2,109 +2,52 @@ import Image from "next/image";
 import { buttonVariants } from "./ui/button";
 import Link from "next/link";
 import { cn } from "@/lib/utils";
+import React from "react"; // Import React


is there is need for this import?

I think I forgot to review imports after changing the CSS codes, I have removed it since we are working React above 17. Apologies for the overlook. Let me anything else required to complete the PR acceptance.
Thank you @ManishBisht777

There is some build error can you check?

I am trying to do, should I check it from Vercel or my local IDE?

1. Removed unnecessary imports from the code -----------------------------------------------

Vishal-raj-1 · 2023-10-21T10:53:20Z

Hey @monisanees270798 any update why preview is failing again and again on this PR?

monisanees270798 · 2023-10-21T11:22:21Z

Hey @monisanees270798 any update why preview is failing again and again on this PR?

I am trying to learn it, I tried clicking on Vercel for the details but it keeps giving me error 404.
I am trying to fix it through my local repository, but if you can let me know what might be causing it would be helpful.

1. Trying to fix Deployment (Hover Effect only) -----------------------------------------------

monisanees270798 · 2023-10-21T12:29:32Z

@ManishBisht777 @Vishal-raj-1
Cheers, all checks have been passed.
Please feel free to accept the PR
Many Thanks

ManishBisht777

LGTM :)

Vishal-raj-1

From next time, try not to change formatting of the file

monisanees270798 · 2023-10-22T13:37:46Z

From next time, try not to change formatting of the file

Sure thing, it was a great learning experience. Thank You.

monisanees270798 added 2 commits October 15, 2023 20:10

Commit Work

15e38f8

1. Rewrote the existing code and added additional hover code in an understandable way (tracks.tsx) 2. A supporting CSS file has been added to styles dir to support hover zoom ----------------------------------------------- I will complete the .md file and initiate a PR

Merge remote-tracking branch 'origin/cursorHover' into cursorHover

fe4c010

github-actions bot reviewed Oct 15, 2023

View reviewed changes

vercel bot had a problem deploying to Preview – frontendfreaks October 15, 2023 09:24 Failure

ManishBisht777 reviewed Oct 16, 2023

View reviewed changes

Commit Work

1f53c91

1. Rewrote the existing code with tailwind CSS only (tracks.tsx) 2. The supporting CSS file has been removed from styles dir -----------------------------------------------

vercel bot had a problem deploying to Preview – frontendfreaks October 17, 2023 00:34 Failure

ManishBisht777 reviewed Oct 19, 2023

View reviewed changes

Commit Work

9eb1a59

1. Removed unnecessary imports from the code -----------------------------------------------

vercel bot had a problem deploying to Preview – frontendfreaks October 19, 2023 11:20 Failure

Merge branch 'master' into cursorHover

cc05182

vercel bot had a problem deploying to Preview – frontendfreaks October 19, 2023 11:32 Failure

Merge branch 'FrontendFreaks:master' into cursorHover

b7b8f89

vercel bot had a problem deploying to Preview – frontendfreaks October 21, 2023 12:04 Failure

Commit Work

3ecdcb4

1. Trying to fix Deployment (Hover Effect only) -----------------------------------------------

vercel bot deployed to Preview – frontendfreaks October 21, 2023 12:17 View deployment

ManishBisht777 approved these changes Oct 22, 2023

View reviewed changes

Vishal-raj-1 reviewed Oct 22, 2023

View reviewed changes

Vishal-raj-1 merged commit cf81f24 into FrontendFreaks:master Oct 22, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cursor hover #218

Cursor hover #218

monisanees270798 commented Oct 15, 2023

vercel bot commented Oct 15, 2023 •

edited

Loading

github-actions bot left a comment

ManishBisht777 left a comment

ManishBisht777 Oct 16, 2023

monisanees270798 Oct 17, 2023 •

edited

Loading

ManishBisht777 left a comment

ManishBisht777 Oct 19, 2023

monisanees270798 Oct 19, 2023

ManishBisht777 Oct 19, 2023

monisanees270798 Oct 20, 2023

Vishal-raj-1 commented Oct 21, 2023

monisanees270798 commented Oct 21, 2023

monisanees270798 commented Oct 21, 2023

ManishBisht777 left a comment

Vishal-raj-1 left a comment

monisanees270798 commented Oct 22, 2023

		@@ -0,0 +1,10 @@
		/* components/Tracks.module.css */

		.image-container {

Cursor hover #218

Cursor hover #218

Conversation

monisanees270798 commented Oct 15, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

vercel bot commented Oct 15, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

ManishBisht777 left a comment

Choose a reason for hiding this comment

ManishBisht777 Oct 16, 2023

Choose a reason for hiding this comment

monisanees270798 Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

ManishBisht777 left a comment

Choose a reason for hiding this comment

ManishBisht777 Oct 19, 2023

Choose a reason for hiding this comment

monisanees270798 Oct 19, 2023

Choose a reason for hiding this comment

ManishBisht777 Oct 19, 2023

Choose a reason for hiding this comment

monisanees270798 Oct 20, 2023

Choose a reason for hiding this comment

Vishal-raj-1 commented Oct 21, 2023

monisanees270798 commented Oct 21, 2023

monisanees270798 commented Oct 21, 2023

ManishBisht777 left a comment

Choose a reason for hiding this comment

Vishal-raj-1 left a comment

Choose a reason for hiding this comment

monisanees270798 commented Oct 22, 2023

vercel bot commented Oct 15, 2023 •

edited

Loading

monisanees270798 Oct 17, 2023 •

edited

Loading