Skip to content

Commit

Permalink
PR feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
thirsch committed Sep 10, 2020
1 parent 9c1ef4e commit 1c64cbd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions lib/mailer/sfMailer.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ public function setDeliveryAddress($address)
public function compose($from = null, $to = null, $subject = null, $body = null)
{
$msg = new Swift_Message();

return $msg
->setFrom($from)
->setTo($to)
Expand Down Expand Up @@ -278,8 +279,8 @@ public function sendNextImmediately()
/**
* Sends the given message.
*
* @param Swift_Transport $transport A transport instance
* @param string[] &$failedRecipients An array of failures by-reference
* @param Swift_Mime_Message|Swift_Mime_SimpleMessage $message The message to send.
* @param string[] &$failedRecipients An array of failures by-reference
*
* @return int|false The number of sent emails
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/mailer/sfNoMailer.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function sendNextImmediately()
return null;
}

public function send(Swift_Mime_Message $message, &$failedRecipients = null)
public function send($message, &$failedRecipients = null)
{
return null;
}
Expand Down

0 comments on commit 1c64cbd

Please sign in to comment.